Closed
Bug 44348
Opened 24 years ago
Closed 22 years ago
Search UI: reset only clears criteria rows, not results.
Categories
(SeaMonkey :: MailNews: Message Display, defect, P4)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.2alpha
People
(Reporter: laurel, Assigned: stephend)
References
Details
(Whiteboard: [ue2])
Attachments
(1 file, 2 obsolete files)
1.50 KB,
patch
|
naving
:
review+
sspitzer
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
Using jun30 m17 commercial build After finding results with one set of search criteria, clicking the reset button only clears the criteria rows and not the previous search results. 1. Go to mail window, open a mail account and login. 2. Search|Search Mail. Select a mail folder, launch a simple search which you know will result in matches --> search results pane opens with the results. 3. Click the Reset button. Result: Only criteria is reset to a fresh state. The results pane still lists the previous search results. Expected: Results should be cleared (if we follow 4.x behavior, the result pane should also disappear) as well as the criteria.
cc jglick for opinion on whether we should take the result pane away on Reset. (not spec'd)
QA Contact: lchiang → laurel
Comment 2•24 years ago
|
||
I'm with laurel - I think they should be cleared.
Both criteria and results pane should be cleared. As for the results pane disappearing when clicking Reset, I don't think that is necessary at long as it goes clear. If the person clicks Reset instead of close, its probably because they want to do another search. So having the result pane close just to reopen again (when next search is done) isn't necessary (and may be annoying for some folks).
Comment 4•24 years ago
|
||
Just a comment - I wasn't planning on ever having the results pane collapse/expand as it does in 4.x...
*** Bug 8720 has been marked as a duplicate of this bug. ***
Comment 10•24 years ago
|
||
marking nsbeta1-
Updated•24 years ago
|
Target Milestone: M18 → ---
Comment 12•23 years ago
|
||
I don't think there should be a Clear button at all. It's gotta be pretty annoying for the user if it accidently clicks the Clear buttons and both all results found *and* the criteria used to find it in the first place gets removed. I vote for invalid.
Comment 13•23 years ago
|
||
having 5 fields in a query and needing to clear them individually just to get a basic search back really sucks... otoh i'm not sure there's a need to clear the results, the moment you search for something else they're cleared, and until then they might be useful to you as you try to build your next query.
Keywords: 4xp
Reporter | ||
Comment 14•22 years ago
|
||
*** Bug 146225 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 15•22 years ago
|
||
Seth's comments from the newer bug: ------- Additional Comment #1 From Seth Spitzer 2002-05-22 11:25 ------- saw this during jglick's UE study, so adding [ue] to status whiteboard. I could of sworn I saw that clear also didn't clear the text area in the first term, but that could have been my imagination.
Whiteboard: [ue]
Assignee | ||
Comment 16•22 years ago
|
||
Assignee | ||
Comment 17•22 years ago
|
||
I've tested this and it works in my tree - I borrowed the logic from Seth's addressbook search code, which get the boxObject, and sets the view property to null. Ours is the same, just named differently, 'treeBoxObject'. In the patch, I also clear out the status feedback text.
Status: NEW → ASSIGNED
Comment 18•22 years ago
|
||
Comment on attachment 97905 [details] [diff] [review] Patch >? navin.txt >Index: SearchDialog.js >=================================================================== >RCS file: /cvsroot/mozilla/mailnews/base/search/resources/content/SearchDialog.js,v >retrieving revision 1.60 >diff -u -7 -r1.60 SearchDialog.js >--- SearchDialog.js 14 Aug 2002 22:12:17 -0000 1.60 >+++ SearchDialog.js 5 Sep 2002 04:34:39 -0000 >@@ -265,17 +265,14 @@ > } > > > function onSearchStop() { > gSearchSession.interruptSearch(); > } > function onReset() { >+ var tree = GetThreadTree(); // get the ThreadTree >+ tree.treeBoxObject.view = null; // assign the TreeBoxObject to null >+ gStatusFeedback.showStatusString(""); // clear out the status tex } > function getFirstItemByTag(root, tag) > { > var node; > if (root.localName == tag) > return root; > > if (root.childNodes) { >Index: searchTermOverlay.js >=================================================================== >RCS file: /cvsroot/mozilla/mailnews/base/search/resources/content/searchTermOverlay.js,v >retrieving revision 1.24 >diff -u -7 -r1.24 searchTermOverlay.js >--- searchTermOverlay.js 3 May 2002 21:58:10 -0000 1.24 >+++ searchTermOverlay.js 5 Sep 2002 04:34:39 -0000 >@@ -446,14 +446,17 @@ > } > > function onReset(event) > { > while (gTotalSearchTerms>0) > removeSearchRow(--gTotalSearchTerms); > onMore(event); > } > > function convertPRTimeToString(tm) > { > var time = new Date(); > // PRTime is in microseconds, Javascript time is in seconds > // so divide by 1000 when converting Note above, I moved those lines to SearchDialog.js. SearchTermOverlay is used by ABSearch code also so you cannot put it here. Also that function should be renamed to OnResetSearch() or something to avoid confusion.
Attachment #97905 -
Flags: needs-work+
Assignee | ||
Comment 19•22 years ago
|
||
Moved the logic into SearchDialog.js, renamed it to onResetSearch(event), and changed SearchDialog.xul to call the newly renamed method onResetSearch.
Attachment #97905 -
Attachment is obsolete: true
Assignee | ||
Comment 20•22 years ago
|
||
Attachment #97911 -
Attachment is obsolete: true
Comment 21•22 years ago
|
||
Comment on attachment 97923 [details] [diff] [review] Patch, ready for final reviews. Calls onReset, to avoid duplicate code. thx, r=naving
Attachment #97923 -
Flags: review+
Comment 22•22 years ago
|
||
Comment on attachment 97923 [details] [diff] [review] Patch, ready for final reviews. Calls onReset, to avoid duplicate code. sr=sspitzer
Attachment #97923 -
Flags: superreview+
Comment 23•22 years ago
|
||
Comment on attachment 97923 [details] [diff] [review] Patch, ready for final reviews. Calls onReset, to avoid duplicate code. a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #97923 -
Flags: approval+
Assignee | ||
Comment 24•22 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 25•22 years ago
|
||
I'm only temporarily reopening this so I can reassign to myself, put a target milestone on it, etc.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 27•22 years ago
|
||
arg, try two. (sorry for spamming you all)
Assignee: naving → stephend
Assignee | ||
Comment 28•22 years ago
|
||
This made 1.2alpha's milestone because it landed on the trunk. Marking fixed.
Status: NEW → RESOLVED
Closed: 22 years ago → 22 years ago
Priority: P3 → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.2alpha
Reporter | ||
Comment 29•22 years ago
|
||
OK using sep16 commercial trunk build: win98, mac OS 10.1, linux rh6.2
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in
before you can comment on or make changes to this bug.
Description
•