Closed Bug 50217 Opened 24 years ago Closed 15 years ago

XUL elements not repainted on reflow triggering by <html> (was Send/Cancel buttons do not work in Ask Me dlg)

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
Future

People

(Reporter: skasinathan, Assigned: eric)

References

Details

(Keywords: platform-parity, Whiteboard: [dogfood-][nsbeta3-] evaughan -- testcase is here.)

Attachments

(4 files, 1 obsolete file)

Workaround, version 1
2.08 KB, patch
Details | Diff | Splinter Review
syntax-updated testcase: part #1 : content\navigator\launchAskSendFormat.xul
777 bytes, application/vnd.mozilla.xul+xml
Details
syntax-updated testcase: part #1 : content\navigator\askSendFormat.xul
1.04 KB, application/vnd.mozilla.xul+xml
Details
screenshot comment #44
64.15 KB, image/jpeg
Details 
steps:
1. bring up compose window and compose HTML msg. Click Send. The "HTML Mail
Question" dialog pops up.  Select one of the option to send as HTML or Plain text.
The 'Send' and 'Cancel' button doesn't work (or unable to click on these two
buttons).

Build and platform:
Today's windows commercial build.
Reassign to Ben.
Assignee: ducarroz → mozilla
We saw this on nbaca's system as well.  It looks like the there may be two
buttons, overlaid on top of each other.  Suresh - try clicking around those buttons.

This should be fixed as soon as possible.   This dialog is new to today's build
and I envision many dupe bug reports on this.
Severity: normal → critical
Summary: unable to send HTML Msg → Send/Cancel buttons do not work in Ask Me dlg - unable to send HTML msgs
Looks like windows bug only. Adding pp keyword.
Nominating for nsbeta3, coz I think most of the users might encounter this (or
those who send HTML msgs).

Workaround: Use the menuitem  Option | Format.
Severity: critical → normal
Keywords: nsbeta3, pp
Summary: Send/Cancel buttons do not work in Ask Me dlg - unable to send HTML msgs → unable to send HTML Msg
We need to dogfood+ this because most users won't look for the workaround and 
this is very easy to run into.
Severity: normal → critical
Keywords: dogfood
Summary: unable to send HTML Msg → Send/Cancel buttons do not work in Ask Me dlg - unable to send HTML msgs
I see this on my NT 4 sp4 system as well.  It appears as if the send button is
lower that it appears in the dialog, so you have to click on the bottom of the
visible send button in order for it to work.  build id: 2000082404
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: --- → M18
I will look into it. Does it appear on Win95, too? I have no NT installed.

> Looks like windows bug only.

Yes, works fine on Linux.
I have a workaround which fixes this problem, but it looks like this is really
an XUL bug. I am adding an icon via stylesheet in the |onload| handler. This
causes the text to rewrap and the buttons to be moved down, but they seem not to
redraw all the time. The workaround is to add any icon per default. (Not a good
long-term solution.) Will attach patch. ducarroz, please review.

Moving over to XPToolkit. Will reassign, when the patch is checked in.

To the new owner:
askSendFormat.js changes the icon via |icon.setAttribute("id", "convert ...|.
The icons are defined in messengercompose.css via |#convertYes {
list-style-image:url("chrome://[...]");}|.
Component: Composition → XP Toolkit/Widgets: XUL
Keywords: review
Product: MailNews → Browser
Putting on [dogfood+] radar.  Yes.  Very commonly used function.  Please fix 
ASAP.
Whiteboard: [dogfood+]
R=ducarroz
*** Bug 50230 has been marked as a duplicate of this bug. ***
tnx for reviewing. Workaround checked in. Removing "[dogfood+]". REASSIGNing to
default XUL owner, including QA.
Assignee: mozilla → trudelle
Status: ASSIGNED → NEW
QA Contact: lchiang → jrgm
Whiteboard: [dogfood+]
fenella reports that the second time the dialog comes up, it works fine. I saw
the same.
*** Bug 50319 has been marked as a duplicate of this bug. ***
Putting on [dogfood-] radar due to workaround.
Whiteboard: [dogfood-]
->hyatt
Assignee: trudelle → hyatt
Attached a simple testcase. If the test case doesn't work initially for you(s), 
adjust the amount of text in the <html> element in askSendFormat.xul file. You 
just need to force a line-wrap when the left-hand box increases its size. [i.e., 
getting this to work depends on fonts and font-sizes].

At any rate, this looks more like a box layout bug ->evaughan
Assignee: hyatt → evaughan
OS: Windows NT → All
Hardware: PC → All
nsbeta3-/future, removing review keyword
Keywords: review
Whiteboard: [dogfood-] → [dogfood-][nsbeta3-]
Target Milestone: M18 → Future
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.8
This test case does nothing when I try it. Can you please verify this is still a
problem?
The testcase still works correctly. However, the two files must be placed
either zipped into a jar file or (if jar packaging is disabled in your build)
into a /content/ directory. This is due to an apparent change in security 
policy since I set this up.

 (e.g. launch as chrome://navigator/content/launchAskSendFormat.xul) 

When the modal dialog is launched (by clicking the button), wait 3 seconds,
and when the reflow occurs, try clicking on the OK/Cancel buttons (they will
be repainted in their new location only after you click them).
->moz0.9
Target Milestone: mozilla0.8 → mozilla0.9
Changed summary to reflect the root cause
Summary: Send/Cancel buttons do not work in Ask Me dlg - unable to send HTML msgs → XUL elements not repainted on reflow triggering by <html> (was Send/Cancel buttons do not work in Ask Me dlg)
*** Bug 66088 has been marked as a duplicate of this bug. ***
not 'critical'
Severity: critical → normal
-moz0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
*** Bug 57473 has been marked as a duplicate of this bug. ***
*** Bug 57473 has been marked as a duplicate of this bug. ***
Whiteboard: [dogfood-][nsbeta3-] → [dogfood-][nsbeta3-] evaughan -- testcase is here.
This test case no longer works. It just gives me some security errors and 
crashes the browser when I try to go back.
See my comments 01/01/2001
> The testcase still works correctly. However, the two files must be placed
> either zipped into a jar file or (if jar packaging is disabled in your build)
> into a /content/ directory. This is due to an apparent change in security 
> policy since I set this up.

(I also tried to get the crash if I just opened into the browser content area, 
but couldn't get the crash).
Keywords: nsdogfood-
Keywords: nsdogfood
->9.3, since workarounds are in place that should suffice for Mojo.
Target Milestone: mozilla0.9.1 → mozilla0.9.3
Target Milestone: mozilla0.9.3 → mozilla0.9.4
going to move this off to 0.9.5.   let me know if this is wrong.
thanks -chofmann
Target Milestone: mozilla0.9.4 → mozilla0.9.5
pushing out
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Target Milestone: mozilla0.9.7 → Future
This testcase is from last year. Does it even work anymore as a test case?
I made some minor updates for changes in XUL syntax, but otherwise the testcase
still works. When the left hand box resizes, the OK/Cancel buttons do not 
update for their new position in the dialog.

Put these two attachments into your comm.jar on path content\navigator, and 
then launch with 
   'mozilla.exe -chrome chrome://navigator/content/launchAskSendFormat.xul'
Attachment #13662 - Attachment is obsolete: true
Does it still happen?
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Needs a windows tester. (I'd like to get rid of the workaround if this is wfm)
(In reply to comment #0)
> steps:
> 1. bring up compose window and compose HTML msg. Click Send. The "HTML Mail
> Question" dialog pops up.  Select one of the option to send as HTML or Plain text.
> The 'Send' and 'Cancel' button doesn't work (or unable to click on these two
> buttons).
> 
> Build and platform:
> Today's windows commercial build.

WFM here on

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090730 Lightning/1.0pre Shredder/3.0b4pre ID:20090730055316

1. I send message, and when pop up "HTML Mail Question" the "Send" button work.
2. I receive the mail sent at step 1.

3. I send message, and when pop up "HTML Mail Question" the "Cancel" button work.
You wouldn't see it in normal use as we have a hack in place to prevent trouble. You'd need to check the testcases attached to this bug.
as in comment  #29 here the testcase don't work... probably I'm wrong any thing but I cannot make testcase to work: it is possible to provide more detail instructions?
Ah yes those don't work anymore. 
If you're comfortable digging around the tb internals, find messenger.jar and remove dialogs.css from it, then retest comment 39. (Jar are zip files so winzip or similar can open them.)
Magnus I'm sorry but in messenger.jar not exist any dialog.css file on my installation.

This confirm that is solved or I can try in another way?
Sorry, it's in classic.jar, not messenger.jar
Attached image screenshot comment #44 — 
I removed dialog.css from classical.jar (located at skin\classic\messenger).

I reproduce steps in comment #39: both buttons work.
I have only the problem that the window "HTML Mail Question" is transparent as show in attached screenshot "comment #44"
Sounds like it's WFM then, might be necessary to only remove the #convertDefault rule from the file to be sure.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(In reply to comment #46)
> Sounds like it's WFM then, might be necessary to only remove the
> #convertDefault rule from the file to be sure.

Confirmed! Removing #convertDefault rule from dialog.css  from classical.jar (located at skin\classic\messenger), all work fine here.
Thanks for checking, Aureliano!!
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: