54402 - Bad accelerator for View->Text Size->Larger

Status: VERIFIED WONTFIX

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Mike Kaply [:mkaply]]

The accelerator for making text size larger is Ctrl++ on the menu.

This is not correct.

The accelerator is actually Ctrl+=

This is obvious because using Ctrl++ on your numeric keypad does not make the 
font larger, whereas Ctrl+- on your numeric keypad does make the font smaller.

Comment 1

[sairuh (rarely reading bugmail)]

jag, would this be yours?

Comment 2

[Peter "jag" Annema]

Hrm... mkaply, can you help me here?

The correct accelerator is ctrl++ (*), but it seems we (well, akkana) had to fix
key handling on linux to make it all work. Would something similar be needed on
OS/2?

*) Actually, these are the keys:
Accel+-       : Smaller (keypad and keyboard -)
Accel++       : Larger  (keypad +)
Accel+Shift++ : Larger  (keyboard +/=, needs the shift 'coz that bit is set)
Accel+=       : Larger  (some people would expect this to work instead)

We need to do three different key combos for Larger because of the way keys are
currently dealt with.

Comment 3

[Mike Kaply [:mkaply]]

I actually opened this as an all bug because I was seeing the problem on 
windows. We'll do whatever we need on OS2 make it work like everyone else.

I guess my complaint is that when I look at my keyboard, there is no such thing 
as (Ctrl + +) unless I use the keypad. There is a + sign above my equal key. But 
if I hit (Ctrl + that key), I am hitting (Ctrl + =) NOT (Ctrl + +)

I understand you are going for a metaphor of some sort here, but the reality is 
that the key next to the minus sign is an equal sign.

So the accelerators should be (Ctrl + -) and (Ctrl + =).

All that being said, I tested (Ctrl+ +) on the numeric keypad on Windows and it 
did not work. And I tested (Ctrl+Shift+=) (which would be the logical equivalent 
of Ctrl+ + on a keyboard) and it did not work. However, (Ctrl+=) did work.

So something is broke here at least on Windows. Either the accelerator needs to 
say (Ctrl + =) or we need to make the (Ctrl + the plus sign on the num keypad) 
work and (Ctrl + Shift + = sign work).

Did that make any sense?

Comment 4

[Peter "jag" Annema]

Ah, yes, I do believe there's a bug open for Windows to get fixed.

And well, I disagree that it needs to say ctrl+=. On my keyboard, it shows a +
to the right of the - key. So, either I would just type ctrl+= (which works) or
type ctrl+shift+= (since shift+= is a +), and that works too.

Comment 5

[Peter "jag" Annema]

See bug 50255 for windows ctrl key bug

Comment 6

[Peter "jag" Annema]

I suggest this be marked wontfix.

All platforms should be able to get "accel +" working, both the main keyboard
one and the numeric keypad one if it exists (we catch both accel + '+' and accel
+ '+' where shift was pressed to get the +).

Currently for convenience we also have accel + '=' working, though '+' may not
always be sharing a key with the '='. I think it's currently impossible to
specify "the key which (also) has a + on it", and feel the metaphore is more
important than using accel + '=' because that happens to be next to the '-' on
most keyboards.

Comment 7

[Viswanath Ramachandran]

Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy

Comment 8

[Chris McAfee]

I think what we have now is fine, I agree with jag.
Marking won't fix.

Comment 9

[Mike Kaply [:mkaply]]

Agreeing - verify WONTFIX