55753 - if order is the first param to buglist.cgi, can't resort

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Jesse Ruderman]

Steps to reproduce:
1. go to url above (http://bugzilla.mozilla.org/buglist.cgi?
order=bugs.bug_id&short_desc_type=substring&short_desc=new%20window)
2. try to resort by clicking on one of the column headers

Result: end up at
http://bugzilla.mozilla.org/buglist.cgi?
order=bugs.bug_id&short_desc_type=substring&short_desc=new%
20window&order=bugs.resolution%2C%20bugs.bug_id 

(notice that the order at the beginning hasn't been removed)


this creates an sql error when it tries to
ORDER BY bugs.bug_idbugs.resolution, bugs.bug_id

Comment 1

[Matthew Tuck [:CodeMachine]]

This strikes me as being in the "trivial category".  AFAICS, this is a hand
entered query, or doesn't come from other cgis?

Comment 2

[Stephan Niemz]

moving to real milestones...

Comment 3

[Dave Miller [:justdave]]

verified this bug still exists.  It produces a nice "Software Error" for the 
user.  I hate Software Errors.  If we don't like it at least spew a user-friendly 
error message.  Probably changecolumns is attempting to scan the query string for 
"?order" but since it's first in this case, it's "?order=" instead, so it's 
missing it.  Should be an easy fix.

Comment 4

[Zach Lipton [:zach]]

moving

Comment 5

[Gervase Markham [:gerv]]

Having looked at colchange.cgi, that doesn't seem to be the problem.

Gerv

Comment 6

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 7

[Gervase Markham [:gerv]]

I've figured this one out.

Gerv

Comment 8

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Correct dodgy regexp. Bug probably due to a misunderstanding of the nature of
$::buffer.

Gerv

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 92146 [details] [diff] [review]
Patch v.1

r=bbaetz

Comment 10

[Gervase Markham [:gerv]]

Fixed.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.186; previous revision: 1.185
done

Gerv