59434 - nsHTTPHandler is not thread safe

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect, P3)

Description

[Darin Fisher]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.16-22 i686; en-US; m18)
Gecko/20001107 Netscape6/6.0
BuildID:    2000110709

nsHTTPHandler is not thread safe.  This could potentially cause all
sorts of havoc b/c calls to nsHTTPChannel::OpenInputStream can spawn
a new thread for the HTTP transaction, which in turn makes calls to
the nsHTTPHandler.  For that matter, even nsIOService appears not to
be thread safe!

This is a serious problem which needs to be resolved.

Reproducible: Always
Steps to Reproduce:
1.<n/a>

Actual Results:  major parts of necko are not thread safe

Expected Results:  we expect that it should be since it is possible to open new
threads from within necko.

Comment 1

[Shawn Wilsher :sdwilsh]

http://mxr.mozilla.org/seamonkey/source/netwerk/protocol/http/src/nsHttpHandler.cpp#1386

It appears to be threadsafe, and like that since revision 1.2 of the file.  Is this FIXED then?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

that doesn't mean that the class is threadsafe, only that its addref and release functions are.

Comment 3

[Patrick McManus [:mcmanus]]

1240568 and 1240569 should address this