632915 - Mozilla does not compile anymore on arm-hardfp

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Oleg Romashin (:romaxa)]

Bug 632162 has been landed even with separate ARM_VFP define MOZ_ARM_VFP_FLAGS, but even with that we still have -mfloat-abi=softfp hardcoded
http://hg.mozilla.org/mozilla-central/annotate/280e978fc6fb//configure.in#l7225

CFLAGS="$CFLAGS -march=armv7-a -marm -mfloat-abi=softfp $MOZ_ARM_VFP_FLAGS"

I'm using hardfp toolchain arm.
sbox-arm-none-linux-gnueabi-g++ ('cs2009q3-hard-67-sb12') 4.4.1

Comment 1

[Mike Hommey [:glandium]]

This should IMHO be handled with bug 626035

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: no hardcoded softfp flag

Comment 3

[Oleg Romashin (:romaxa)]

hmm I tried second patch in that bug and got another error:

checking for valid optimization flags... no
configure: error: These compiler flags are invalid: -Os -freorder-blocks -fomit-frame-pointer

Comment 4

[Oleg Romashin (:romaxa)]

"alternative proposal" also  does not help with this problem (it does not solve that at all)

Comment 5

[Mike Hommey [:glandium]]

(In reply to comment #4)
> "alternative proposal" also  does not help with this problem (it does not solve
> that at all)

no, but the problem is that fiddling with build flags should be done in .mozconfig, not configure.in.

Comment 8

[Oleg Romashin (:romaxa)]

Comment on attachment 511109 [details] [diff] [review]
no hardcoded softfp flag

obsolete

Comment 9

[Oleg Romashin (:romaxa)]

Attachment: Detect HRDFP in configure and disable softfp only in that case

Comment 10

[Oleg Romashin (:romaxa)]

sounds like bug 626035 does not have good progress...
Can we apply this patch (it should be safe for maem/android) and not required any mozconfig changes

Comment 11

[Mike Hommey [:glandium]]

Comment on attachment 526595 [details] [diff] [review]
Detect HRDFP in configure and disable softfp only in that case

I think what we need is a configure flag, e.g --with-arm-float-abi, passing its value to -mfloat-abi when there is one, and with appropriate defaults for the different platforms. This is the way forward for bug 626035 as well (comment 50).

Comment 12

[Mike Hommey [:glandium]]

I'm pretty sure this is not an issue anymore with the various changes that happened to the build system (and Debian packages do build fine on armhf)

Comment 13

[pbrobinson]

looking at xulrunner 9 in Fedora all the options look to be there in configure to set all the various hard/soft and the type of FP unit.