Closed Bug 68138 Opened 23 years ago Closed 23 years ago

Paragraph style toolbar menu is broken after direct edit of HTML source

Categories

(Core :: DOM: Editor, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: gtr, Assigned: hyatt)

References

Details

(Keywords: regression)

Build 2001020721, on Solaris 8.

After vewing and editing HTML source to correct errors introduced by the mozilla
editor, the menu for selecting type of HTML element is broken.

Actual results: clicking on the button to pull down the menu does not produce
the menu, even momentarily.  Mozilla says on the console:

JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIMenuBoxObject.activeChild]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> ::
onxblcreate :: line 5"  data: no]

Expected results: menu appears when button is clicked.

Repoducible: no. When I closed the editor (File->close command) and restarted
it, the menu started working again.

These are other errors seen on the console in the few minutes that I've had this
build running:

Updating wizard map..
Accounttype is mail: undefined
Handle other types () here?
initializing ISP data for mailaccount
AccountWizard.prefillAccountForIsp(mailaccount)
PrefillAccountForISP: filling with null
null account data! clearing..
This is an accountdata
Updating wizard map..
Accounttype is mail: undefined
Handle other types () here?
failed to do sort
failed to get command manager number 3
failed to get command manager number 2
Registering commands
Have Find = true
Have SpellChecker = false
JavaScript error: 
chrome://communicator/content/securityUI.js line 29:
Components.classes['@mozilla.org/secure_browser_ui;1'] has no properties

Error loading URL http://bugzilla.mozilla.org/post_bug.cgi: 804b0002 
*** PRE date = 267
*** POST date = 275
Document http://bugzilla.mozilla.org/enter_bug.cgi loaded successfully
*** PRE date = 877
*** POST date = 379

failed to get command manager number 3
failed to get command manager number 2
confirmed problem using build from 2/8/01 on win32 -- to repro:
1. open blank composer window
2. in Normal mode, enter some text
3. toggle to Source mode, put a <P> tag around the text
4. toggle to Normal mode and select the element selection drop down, it is 
locked, no matter what you do
Assignee: beppe → cmanske
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Target Milestone: --- → mozilla0.9.1
yuck! Another UI problem (not editor-specific)! What is going on?
You don't have to edit anything in HTML Source mode; simply switching to and from
it back to Normal kills the paragraph menu.
This must be fixed soon.
Status: NEW → ASSIGNED
Summary: Element-selection menu is broken after direct edit of HTML source → Paragraph style toolbar menu is broken after direct edit of HTML source
Target Milestone: mozilla0.9.1 → mozilla0.9
*** Bug 69388 has been marked as a duplicate of this bug. ***
this should go to hyatt (see bug 67944 which has exactly the same error, but not
in the same place). However since it's already assigned I'll let the assignee
reassign himself
OS->All
OS: Solaris → All
Hardware: Sun → All
We probably should just dup this to 67944, but I'll keep it with the depend
to track the problem.
Depends on: 67944
Curious. Bug 67944, which is reckoned to have the same cause, is reported fixed,
but this current bug is still present in build 2001022521.
This has to be more subtle than bug 67944, which is really fixed (probably by
Hyatt's checkin on 19th feb). No idea what is up however, so CC'ing Hyatt and
adding regression keyword.
Keywords: regression
The reason for this problem is that the "FormatToolbar" is hidden during
HTML Source mode.  After returning to Normal mode, we see this error in output:
JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code: 0x8
0004005 (NS_ERROR_FAILURE) [nsIMenuBoxObject.activeChild]"  nsresult: "0x8000400
5 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> :: onxblcreate
:: line 5"  data: no]

Note that you will get the same error when you use "View | Toolbar | ..."
submenu to hide/show a toolbar, so any module that has menulist in a toolbar
will show this problem.
I debugged this with hyatt and he'll take the problem.
Note: We probably should change from using "hidden" (resulting in display: none
CSS) to some other attribute name which uses "display: collapsed" instead so
we don't destroy frames. Currently, the "collapsed" attribute on a toolbar
does not completely collapse the box, but leaves the small-height region so
toolbar can be reactivated. Maybe we should use "tb-collapsed" instead for this
behavior so the "collapsed" attribute behaves consistently for all widgets.
Assignee: cmanske → hyatt
Status: ASSIGNED → NEW
*** Bug 70503 has been marked as a duplicate of this bug. ***
Fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified as fixed on Solaris 8, Mozilla build 2001061722. 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.