Closed Bug 68572 Opened 24 years ago Closed 23 years ago

sidebar tabs with login/password fields aren't 'saved' using Password Manager ( psm problem ??)

Categories

(SeaMonkey :: Sidebar, defect)

Product:
SeaMonkey
Component:
Sidebar
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME
Milestone:
mozilla0.9.6

People

(Reporter: roaminglt, Assigned: morse)

References

(
URL
)

Details

Add the Hermes sidebar tab from the following url 
(http://hermes.mozdev.org/installation.html) choose the 0.2.x version.

Try using one of the account services eg Hotmail and when 'Password manager' 
pops up and asks if it should save the details choose 'Yes' but details are 
then not saved. Using several different user names on the same service 
(hotmail) one would expect the password manager to pop-up a choice to pre-fill 
your details.. this doesn't occur

This shows on:

Win98 Build ID: 2001021020

I expect the Password Manager to work for the sidebar exactly how it works for 
main pages.

p.s. PSM doesn't seem to currently be functioning properly for me to use 
Hotmail anyway so it's hard to check properly.. but that's an unrelated problem.
I think this is the person who created the sidebars problem. Not ours...Anyone else? Thoughts?
Marking INVALID.
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → INVALID
heya Kso.. umm.. any chance you can explain why you are marking this INVALID?
Can you not get this bug to reproduce?
verified in 3/20 build.
Status: RESOLVED → VERIFIED
verified invalid?
Does that mean you don't see the problem?
Last I saw the password saved was fixed in relation to the page in the main 
window.. and not the actual sidebar. So that with a different page in 
your '_content' would prevent the password being recalled.
Have you tried this with different main pages on display?
I'll try and re-open if I still see the bug
Reopening after talking to Azrael.
Status: VERIFIED → UNCONFIRMED
Resolution: INVALID → ---
Additional:

Mozilla is currently (sometimes anyway) popping up the password save box on 
Hermes (sidebar panel with login/password fields). Yet the password saving 
isn't working properly. Some have suggested it is saving the password in 
relation to the main page as opposed to the sidebar, and thus recalling it 
depends on what the main page is.
Either Mozilla should handle this properly.. or Mozilla should _never_ treat 
sidebar tabs with user/password fields as something to save.
Either way this is a bug and personally I would like to see password saving 
handled properly in the sidebar. But at least not working badly.
You can probably determine whether a password was saved and, if so, under what
name by using the "View Stored Passwords" screen.  You can get to this under the
"Tasks" menu or through the prefs screens.
Marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
-> morse
Assignee: matt → morse
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
As the original reporter.. just letting you know I am still keeping an eye on 
this bug in case you wish to ask questions etc about it that I might be able to 
answer.
I am unable to reproduce.  The password manager never pops up when I submit a 
login to any of the services in the hermes sidebar.

Reporter, is this 100% reproducible for you?  Also you said that password 
manager (I assume that's what you meant by PSM, rather than Personal Security 
Manager) is not currently working for you with hotmail.  So which hermes service 
are you using to demonstrate this problem?

Just to add more confusion.. hermes now is a .xml file.. and so is ignored by 
the password manager.. which frankly I'm not sure if it should or not. But 
that's beside the point.

This bug refers to Hermes when it was using .html files.

To see this bug you should use an older version.. specifically I have just 
replicated this on: Hermes 0.2.2
Add 'Hermes - 0.2.2' to your Sidebar
and try it with that.
The password manager does pop up, and will prompt to save data.. but after 
saving two sets of data.. I am not prompted for which to fill in.
If this can be fixed.. that would be great.. however I would also like password 
manager to be active when dealing with .xml files.. but am guessing that is a 
different bug...
Target Milestone: mozilla0.9.5 → mozilla0.9.6
OK, I installed Hermes 2.2.  Now the password manager is indeed popping up.  But 
it is also correctly saving and restoring.  So this is working fine for me.

Terri, are you able to reproduce?  Is anyone other than the original reporter 
able to reproduce?
Strange.  The first time I tried this immediately after installing hermes, 
password-manager indeed saved my password.  But now it is not saving it.  
Something strange is certainly going on here.  I'll investigate further.

And, yes, the saved password was indicated as being for the page being viewed 
and not for the sidebar panel.
> And, yes, the saved password was indicated as being for the page being viewed
> and not for the sidebar panel.

Correction: it's the other way around.
Can I ask. Is it clearly defined somewhere what sorts of files password manager
will respond to? eg *.html?
And if so is it a simple change to also affect other files.. eg *.xml or *.xul ??
Password manager is notified whenever a page finishes loading and whenever a 
form is submitted.  At that time it walks the dom looking for password fields.  
It doesn't know about HTML or XML or XUL -- all it knows is DOM.
Umm.. I kinda assumed.. from my work on hermes.. and the change form .html to
.xml ... that it was related to file extension. As _that_ was when the password
manager no longer appeared.
Can you tell with a cursory glance why the later versions of hermes... using
forms.. _wouldn't_ trigger the password manager then?
I can't answer that until I do further investigation.
OK, after some more thorough testing I can now report the following:

Password manager is working fine for the hermes sidebar panel for Hotmail, 
Netscape, NetAddress, USA.com, and Another.com.  In all cases I get asked if I 
want to save the password when I submit, and the password is prefilled for me 
when I return to it.

Password manager is not working for yahoo but that's because yahoo has opted out 
of password manager.

There is one problem that I am seeing however.  Specifically, I log in with two 
different usernames at a particular hermes site, netscape for example.  Then 
when I close and reopen the hermes tab I am asked to chose which user I want.  
That's fine.  Then repeat this for two different users at another hermes site, 
hotmail for ex.  Again I close and reopen the hermes tab.  But this time I would 
expect to be prompted to chose a user for both hotmail and netscape.  But I am 
prompted only for hotmail.  I need to investigate this a little further.
of course chose -> choose in two places above.

One more problem but this has nothing to do with password manager.  If I enter 
an incorrect login for netaddress, usa.com, or another.com, the display in the 
hermes sidepanel is dedicated to telling me there was an error and provides no 
way for me to restore the hermes panel.  I must close the hermes tab and then 
reopen it.  If I do an incorrect login for the others, the hermes sidepanel 
display remains intact.  I don't know enough about the hermes sidepanel to know 
if that is expected behavior or not, so I'll leave it to the hermes experts to 
open a bug report on that if that is a bug.
OK, here's the reason that the user-selection is occurring only once.

The password manager keeps track of the fact that it already put up the 
select-user dialog for the particular form.  That prevents it from asking the 
question repeatedly if layout is called repeatedly for the same form.  In the 
case of the sidebar panel, all the logins appear to be on one form.

Still investigating to see if there is anything that can be done about that.
OK, the problem with getting only one select-user dialog has nothing to do with 
the sidebar panel.  It can be demonstrated with simple html file.  I just opened 
bug 104327 to cover that problem.

So I don't see anything left in this bug report.  Password manager works fine 
for all those values in the hermes sidebar except yahoo, and that's because 
yahoo has opted out of the password manager.  Closing this out as works-for-me.

If you think there is still a problem, then please give a detailed step-by-step 
procedure for reproducing it and reopen this report.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → WORKSFORME
verified.
Status: RESOLVED → VERIFIED
Wow.. thanks for all the effort morse :)
A little question.. I started getting confused about what version of Hermes you 
were reffering to.
In hermes 0.2.8 each 'service' in hermes is on a seperate form.
You say password manager is showing up.. but is that for the older version of 
hermes.. or the current one?
I am considering opening a new bug about password manager not operating for 
*.xml files (eg Hermes 0.2.8) - but if you are getting it working in Hermes 
0.2.8 then something is fried on my end.
Per the commment from Azrael AOD 2001-09-26 05:45, I am using 0.2.2
BTW, I should correct one thing that I said above that was not accurate:

> The password manager keeps track of the fact that it already put up the 
> select-user dialog for the particular form.

That should read "page" instead of "form".  And then entire hermese panel is 
being treated as a single page.
Ahh.. that's suddenly making alot of sense.
So let me see if I understand the mechanics of this.. :)
Password Manager stores passwords relating to the page they are from.. and not 
from what specific form on a page.

again.. thanks for the help morse :)

That is correct.  With hindsight we might argue that it should have been 
specific to a form instead of a page.  But currently it is stored by page and 
not by form.
Well. far be it from me to suggest such a change... after all I can barely 
think of an occasion it would be relevant.. however... if there is room for 
improvement.. should I make an rfe? Even if it is only for build 1.something? :)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.