70274 - right-clicking should cancel link/text drag

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Select some text, or find a link to drag.
2. Drag it anywhere (within current window, over desktop, etc.) but don't drop 
it yet.
3. Right-click.

Result: nothing happens when I right-click.
Expected result: right-click should stop the drag.

(Pressing escape does stop the drag.)

Comment 1

[Blake Ross]

Well, we can't process events during a drag.  Until we can...

Comment 2

[Jesse Ruderman]

Blake, is there a bug about being able to process events during a drag that this
bug can be marked as depending on?

Comment 3

[Blake Ross]

-> event handling

Comment 4

[Judson Valeski]

interesting thing is that I can cancel the drag by hitting the ESC key, so, we
must be handling *some* events during drag.

Comment 5

[Michael Dunn]

plusing per edt

Comment 6

[saari (gone)]

Is this really a topembed+ bug?

->radha, should be easy to just check for the right click event during the drag
and cancel the drag since we're capturing mouse events at that point anyway

Comment 7

[Radha on family leave (not reading bugmail)]

I can't get this in before next tuesday. I'm still recovering from the timeoff.

Comment 8

[Radha on family leave (not reading bugmail)]

In both windows and linux, when I press the right button while a drag is in
session, the native DragDropOver callbacks are called. No event for the right
button down, up or click is generated. No event is generated for any key presses
also except for the 'Esc' key.  This makes me want to believe that after the
mouse is grabbed for the drag operation, the OS does not pass on events to the
browser except for those that  exits the drag operation like the  'Esc' key
event and the left button up.  I see this behavior in both linux and windows. 

In linux, other applications also do not respond to the right button down while
a drag is on, like the text editor application and the directory viewer. However
in windows other native applications like the windows explorer and IE do respond
to right button down and cancel the drag.  

Comment 9

[Radha on family leave (not reading bugmail)]

Based on my previous comment, I don't see a way to fix this. Marking Won't fix. 

Comment 10

[:deanis74]

I'm going to take a look at this.  IE6 supports this behavior, so it's
definitely possible.  I have an idea or two of how this may be possible.

Comment 11

[:deanis74]

Mine.

Comment 12

[:deanis74]

Attachment: patch

This does it.

1. It pops up a context menu when you release the right mouse button, but
that's pretty much in line with our not eating clicks policy.
2. You can't start a drag if you already have the right button down, but that
doesn't make sense anyway.  I could get around this by introducing a member
variable that knows whether the right button was down or not, but I really
don't see the benefit.

Comment 13

[:deanis74]

Comment on attachment 115959 [details] [diff] [review]
patch

Ere, can you review this?

Comment 14

[Ere Maijala (slow)]

Looks good, but I've yet to actually test it.

Comment 15

[Ere Maijala (slow)]

Comment on attachment 115959 [details] [diff] [review]
patch

Actually it doesn't do what I think it should. Clicking the right button while
dragging should cancel the drag and not end it, right?

Comment 16

[:deanis74]

Comment on attachment 115959 [details] [diff] [review]
patch

Hee hee.  Whoops!

Comment 17

[:deanis74]

Attachment: patch v2

cancel the drag, don't complete it

Comment 18

[:deanis74]

Comment on attachment 116052 [details] [diff] [review]
patch v2

Ere, this one's better.  Right-click is now handled in the same check as esc
being pressed.

Comment 19

[Ere Maijala (slow)]

Comment on attachment 116052 [details] [diff] [review]
patch v2

Yep, that's better :) r=[e-mail]

Comment 20

[:deanis74]

Comment on attachment 116052 [details] [diff] [review]
patch v2

Jag, can you sr= this simple addition?

Comment 21

[jag (Peter Annema)]

Comment on attachment 116052 [details] [diff] [review]
patch v2

sr=jag

Comment 22

[:deanis74]

checked in

Comment 23

[Wayne Mery (:wsmwk)]

doesn't cancel drag any more. escape does cancel. did the specs change, or did this regress?  

if it regressed, there is jst's whitespace patch, bug 203307 and anything that happened between 2003-03-06 and 2005-03-30 - I tested Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050330) where right click also doesn't cancel drag

https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=right+click&product=Core&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&resolution=FIXED&bug_severity=blocker&bug_severity=critical&bug_severity=major&bug_severity=normal&bug_severity=minor&bug_severity=trivial&bug_severity=enhancement&op_sys=All&op_sys=Windows+95&op_sys=Windows+98&op_sys=Windows+ME&op_sys=Windows+NT&op_sys=Windows+2000&op_sys=Windows+XP&op_sys=Windows+Server+2003&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=2003-03-06&chfieldto=2005-03-30&chfield=resolution&chfieldvalue=fixed&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=