Closed Bug 72823 Opened 23 years ago Closed 16 years ago

implement Select | Flagged (Star) messages

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sspitzer, Assigned: Bienvenu)

Details

Attachments

(2 files)

Proposed patch
4.09 KB, patch
Bienvenu
: review+
Details | Diff | Splinter Review
[checked in]TB port
5.75 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review 
for 4.x parity
QA Contact: esther → fenella
I implemented "Select | Thread", so I added "Select | Flagged" as well.

but Select Flagged isn't finished (in nsMsgDBView.cpp) so it is always disabled.
Status: NEW → ASSIGNED
Seth: Do you know when Flagged messages will be implemented?
QA Contact: fenella → laurel
Keywords: useless-UI
Keywords: useless-UI
This would presumably now be   Edit | Select | Flagged messages
Attached patch Proposed patch — — Splinter Review 
Assignee: sspitzer → neil.parkwaycc.co.uk

    
  

        Attachment #141359 -
        Flags: review?(bienvenu)
Product: Browser → Seamonkey

    
    

    
  
Comment on attachment 141359 [details] [diff] [review]
Proposed patch

sorry for missing this review request...I think not expanding is probably the
right thing to do.

        Attachment #141359 -
        Flags: review?(bienvenu) → review+

    
    

    
  
Fix checked in to suite; FE needs TB port.
Assignee: neil.parkwaycc.co.uk → mscott
Status: ASSIGNED → NEW

    
    

    
  
I'll port to thunderbird.
Assignee: mscott → bienvenu

    
    

    
  
(In reply to comment #6)
> Fix checked in to suite; FE needs TB port.

that's bug 277982

    
    

    
  
(In reply to comment #8)
> > Fix checked in to suite; FE needs TB port.
> 
> that's bug 277982

That bug is about using flag as a filter/search criterion; different issue.

    
    

    
  
(In reply to comment #7 : David Bienvenu, 2005-01-14)
> I'll port to thunderbird.

How about it, David?

    
    

    
  
(In reply to comment #10)
> How about it, David?

Actually, I don't see much need for this feature now that Bug 272709 (and all of its many duplicates) has been implemented.  It is easy enough to create a "Flagged" view, which displays only flagged messages ("Status is Flagged"), and then use the Select All command to achieve what this bug is requesting.

Alternatively, it would be nice if this "Flagged" view was created automatically, so it appears in the list of canned views by default.

    
  
Summary: implement Select | Flagged messages → implement Select | Flagged (Star) messages

    
    

    
  


  

        Attachment #328026 -
        Flags: review?

    
  

        Attachment #328026 -
        Flags: review? → review?(mkmelin+mozilla)

    
    

    
  
Comment on attachment 328026 [details] [diff] [review]
[checked in]TB port

Sure! r=mkmelin

        Attachment #328026 -
        Flags: review?(mkmelin+mozilla) → review+
QA Contact: laurel → front-end
Hardware: PC → All

    
  

        Attachment #328026 -
        Attachment description: TB port → [checked in]TB port

    
  
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

    
    

    
  
I changed Flagged to Starred and the access key from F to S in messenger.dtd before checking in.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: