74845 - W3C CSS2+ class names support underscores (_)

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[James Green]

The W3C Errata page at
http://www.w3.org/Style/css2-updates/REC-CSS2-19980512-errata now gives support
for the underscore (_) character in CSS class names.

Example:
   a.foo-bar { text-decoration: underline; }
could now be
   a.foo_bar { text-decoration: underline; }
too.

This apparently needs to be done to be conformant with xml 'name'... Needs to be
added to Mozilla ASAP to prevent more bugs filed by web authors who are already
using _ as IE5 supports it I believe *sigh*.

Comment 1

[James Green]

-> Daniel who says he can do this quickly.

Comment 2

[rubydoo123]

moz0.9

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: easy fix for 74845

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Accepting assignment.

Easy 1-line fix proposed above. Since this errata derives from the XML spec
stating :

  [4] NameChar ::= Letter | Digit | '.' | '-' | '_' | ':' | CombiningChar | Extender
  [5] Name ::= (Letter | '_' | ':') (NameChar)*

all NAME identifiers should be able to contain an underscore or start with an
underscore.

r= and sr= needed please.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: test case for underscores in css identifiers

Comment 6

[Boris Zbarsky [:bzbarsky]]

r=[e-mail]

testcase looks good with the patch.

Comment 7

[Marc Attinasi]

sr=attinasi

Comment 8

[Pierre Saslawsky]

r=pierre

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in

Comment 10

[James Green]

Verified fixed on Linux, can someone do the same on Mac/Win32 please.

Comment 11

[Hixie (not reading bugmail)]

verified by testcase