Closed
Bug 755388
Opened 12 years ago
Closed 12 years ago
"hud is null" when using the edit gcli command
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: dcamp, Assigned: jwalker)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file)
21.99 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
This is frankly a huge patch for what it effectively a 2/3 line change (See GcliCommands.jsm). In addition to fixing the problem we: - Fix a related issue in GCLI https://github.com/joewalker/gcli/commit/3f33b1bf9440e20b067a99e76823ecd51c3e4f8c I'm not sure it's worth a pull request when you can see it here - Adding tests for the 'edit' command (See bug 759853 for a follow-up to complete this work) - head.js wasn't implementing 'markup' checking. I added that in The code was in the GCLI version of this - Renamed test->tests to fall inline with the GCLI version - Fixed tests in pref command as a result of 'markup' not being implemented - Added my leakHunt code. I find it very useful for finding memory leaks and I keep adding it and removing it. I'm leaving it in here to see what people think of it.
Reporter | ||
Updated•12 years ago
|
Attachment #628479 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=a24414165cd4
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 15
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3e0e827bd236
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•