Closed Bug 78686 Opened 23 years ago Closed 23 years ago

File Button broken in Search Dialog

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows NT
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: gayatrib, Assigned: hewitt)

References

Details

Attachments

(1 file)

In build 5/2/2001 -- after the new file button has landed -- file button is 
completely broken.
Marking bug 76401 dependent on this one.
Blocks: 76401
Status: NEW → ASSIGNED
I verified and this is happening only in the modern skin.

The reason is file button is broken is, when clicked, an error message is 
printed saying:
MsgMoveMessage failed: [Exception... "Component returned failure code: 
0x80004002 (NS_NOINTERFACE) [nsIRDFResource.QueryInterface]"  nsresult: 
"0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: 
chrome://messenger/content/SearchDialog.js:: MoveMessageInSearch :: line 631"  
data: no]

And the reason this is happening is that, it is returning the name of the button 
when event.target.id is called, as opposed to a selected folder.

This is getting called as soon as the button is clicked--as opposed to when 
something is selected and an actual move/copy is done.
Assignee: gayatrib → hewitt
Status: ASSIGNED → NEW
changing summary line.
Summary: File Button broken → File Button broken in Search Dialog
Upping the severity.
Severity: normal → major
Keywords: nsbeta1
QA Contact: esther → laurel
*** Bug 78550 has been marked as a duplicate of this bug. ***
Adding mailtrack keyword. This bug prevents us from testing move/copy 
on search window. cc putterman. 
Keywords: mailtrack
Themes Triage Team marking nsbeta1+
Keywords: nsbeta1nsbeta1+
Target Milestone: --- → mozilla0.9.1
Blocks: 75812
Status: NEW → ASSIGNED
The following patch is a bit large, so I'll describe what I did to help
reviewers parse it:

1. added a binding for single menubuttons to modern and classic mac/win
2. added an insertion point into all button bindings so that the drop-down arrow
could be placed inside a standard button while it is used in a menubutton
3. added styles so that open menubuttons maintain depressed appearance
4. removed dead, commented out styles from classic mac/win menubutton.css
5. fixed indentation in SearchDialog.xul, as it was pretty awful to begin with
Attached patch patch to fixSplinter Review
looks ok to me. r = andreww
The File button also appears smaller than Open and Delete buttons.  Is that a 
separate bug?
No there's not a separate bug, long story, lots of confusion in another bug. 
I'll log a separate one since every time we add little side issues to a bug they
get lost in the shuffle.  New one is bug 82139
*** Bug 81239 has been marked as a duplicate of this bug. ***
sr=mscott
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
OK using may21 commercial trunk build, win98.
Can't yet verify on other platforms today, but assume OK there, too. I'll notice
it real quick if it's not ok. Marking this verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: