786982 - The user should be able to close the last remaining tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Rouget [:paul]]

As a user, I'm frustrated to not be able to get rid of the last tab.

Let's imagine I want to look for a ring for my fiancé. Once my browsing session is done, I want to close the last tab that shows a big fat embarrassing ring. The only way I can do that is to load a new random page.

Closing the last page could load about:home. Or maybe go to a tab-less browser.

Comment 2

[donrhummy]

> Or maybe go to a tab-less browser.

This is what Chrome does. I think this is the best way to do it but loading a home page would also be ok.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Option 1

This patch closes the last tab and opens about:home.
We loadUrl() about:home, when we know we are about to close the last tab.

If the only tab remaining is about:home, we close it and open it again.
Do we want this behavior? Or block the ability to close the tab when the only present tab is about:home?

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Option 2

I somehow feel this to be better. We don't close "about:home" tab in this case.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Part of the reason people want to be able to close the last tab is to remove all session history in the tab (back/forward session). If we don't realy close the last tab if it's about:home, then people could use BACK to go back to the previous webpage in the tab. We do not want to allow that to happen.

Therefore, I will r- the "Option 2" patch and review the "Option 1" patch

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 678490 [details] [diff] [review]
Patch: Option 2

This does not remove the session history, so it's not the best option.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 678476 [details] [diff] [review]
Patch: Option 1

This looks OK to me. We might want to tweak this by avoiding any unneeded animations, if we can help it. That can be a new bug though.

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 678476 [details] [diff] [review]
Patch: Option 1

Review of attachment 678476 [details] [diff] [review]:
-----------------------------------------------------------------

You're removing a bit too much code for the close button handling. We hide the close button while swiping, this code should be kept.

Comment 10

[alex]

I would like the "close and reopen" behaviour more, because its visible feedback "the browser was empty, now everything is in a new session".

Even better would be some "empty browser" behaviour, maybe with an additional option to open about:blank instead of about:home

Comment 11

[Sriram Ramasubramanian [:sriram]]

Pushed with r+ from mfinkle:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/3e84fd8b78aa

I don't get any mail notification for the other r-. I'll add as a followup.

Comment 12

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Make close button invisible

This patch adds back the close button code for animation.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e84fd8b78aa

Comment 14

[Lucas Rocha (:lucasr)]

Comment on attachment 678820 [details] [diff] [review]
Patch: Make close button invisible

Review of attachment 678820 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

Comment 15

[Ian Barlow (:ibarlow)]

One comment on today's Nightly: Closing the last tab should probably close the tabs tray as well. It feels awkward switching to about:home, but still leaving the tray open.

Comment 16

[Ian Barlow (:ibarlow)]

Filed follow up bug 811738 for what I just said :)

As you were.

Comment 17

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2d096e0ac89e

Comment 18

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Brian Nicholson (:bnicholson) from comment #17)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/2d096e0ac89e

If this part does not make the merge, we should track it for uplift

Comment 19

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2d096e0ac89e

Comment 20

[Brian Nicholson (:bnicholson)]

Sriram, the second part of this didn't make Fx19 - see comment 18.

Comment 21

[Sriram Ramasubramanian [:sriram]]

Aah! You caught me!

Comment 22

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 678820 [details] [diff] [review]
Patch: Make close button invisible

[Approval Request Comment]
Bug caused by (feature/regressing bug #): --
User impact if declined: Close button will be animating.
Testing completed (on m-c, etc.): Landed in m-c on 11/20
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.

Comment 23

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 678820 [details] [diff] [review]
Patch: Make close button invisible

low risk, aurora approved.

Comment 24

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c2e87d10933

Comment 25

[Cristian Nicolae (:xti)]

The last tab can be closed both on the latest Aurora and Nightly builds. Closing bug as verified fixed on:

Firefox 20.0a1 (2012-12-06)
Device: Galaxy Tab2 7"
OS: Android 4.0.3

Comment 26

[Ioana Chiorean]

TCs added in Moztrap with new option for following versions: 19, 19 tablets, 20 , 20 tablets 

https://moztrap.mozilla.org/manage/case/5881 - Close the last remaining tab
https://moztrap.mozilla.org/manage/case/5882 - Closing last tab will open about:home