Closed Bug 82015 Opened 23 years ago Closed 22 years ago

Search/Filters UI: AND/OR text not always appearing until AND/OR toggled

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED WORKSFORME
mozilla1.0.1

People

(Reporter: laurel, Assigned: naving)

References

Details

(Whiteboard: [ue])

Attachments

(1 file)

Using may21 commercial trunk build

This has changed, not sure when. It used to always appear, although I know we
have other bugs such as bug 57355 about the text appearing too soon with a
single criteria line.

Now the "and the" or "or the" text may not appear for several criteria lines
until the AND/OR radio button selection is toggled.

Happens in both Filter Rules and Search Messages dialogs, both classic and
modern skins.


1.  From mail window, Search|Search Mail/News Messages.
2.  Leave the radio button to default selection for AND/OR -- "match ALL..."
"match at least ONE..."
3.  Click the More button a couple times to add a couple criteria lines.  Notice
there is no "or the" text appearing in the left-hand side of the criteria lines.
4.  Toggle the radio button for AND/OR.  Notice now the "and the" or "or the"
text appears.

Note:  seems to be several step variations when this text will appear or not appear.
QA Contact: esther → laurel
With some step variations text may not appear at all for several lines or may
appear on one line and not the other, example of the latter attached.  We need
to make the appearance/changing of the text consistent.
Hmm, it looks like filter UI and search UI have different symptoms here --
filter ui (using may23-24 commercial build) isn't displaying the text at all.  
Keywords: nsbeta1, ui
Definitely sloppy looking that it works only sometimes in Search and not at all 
in Filters.
Priority: -- → P3
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
moving to 0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Jennifer: Have we made a firm decision never to have the AND the/OR the text
ever appear in either UI?  On the trunk, I guess with hwaara's fix(es), we now
don't show any text (and we don't recapture that space with the criteria rows).
 Please let me know... 
Laurel, my understanding is that this and/or thing was supposed to go away
because of the following reasons:

* It has caused more problems than it has gained usability.
* It looks silly (IMHO)
* It is not necessary, because the radiobutton text reads "All/Any of the
following:" which means that you don't need to have and/or unless you really,
really want it.

What do you think?
I abide by what Jennifer decides. If I remember right, the original intent was
to provide additional clarification for less experienced users which is often
touted as our (commercial) target.  I am employed by the commercial endeavor, I
abide by what the commercial UI decision is.
I think the And/Or is useful if we could get them to work properly. This type of 
logic is often difficult for non-math/computer science people to understand. 
That Any=Or and All=And may not be obvious to many folks, so the added text 
helps clarify what the filter is actually going to do.  (I remember in a Logic 
course I took, it was common for folks to switch the two, thinking Any=And and 
All=Or).

That said, with this feature Not working, I think the empty gaps in the 
beginning are sloppy/messy looking.  Do we think there is a good chance of this 
getting fixed?  If we can't implement this correctly, the spaces should be 
removed.
Depends on who you're asking. (If it's me:)

I understand that this feature could be useful, however, from a technical point
of view, I don't think it's worth it.

The major part of the code squandered around the tree to support this feature is
old and buggy, which is the main reason I won't use effort to fix it. There are
far more important problems in filters/search I'll attempt to fix than that.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Mail news triage meeting --> .9.5
Target Milestone: mozilla0.9.4 → mozilla0.9.5
moving to 0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
moving to 1.0
Target Milestone: mozilla0.9.6 → mozilla1.0
Blocks: 104166
Keywords: nsbeta1
Whiteboard: [nsbeta1+]
Keywords: nsbeta1nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.0.1
This will become fixed when bug 40356's fix gets checked in.
Depends on: 40356
Nominating for cleanup in next release -- This is useless space at this point,
we should either make the AND/OR work again or remove the excess space to make
the dialog a little more polished.  Also see bug 40356.

Keywords: nsbeta1-nsbeta1
Whiteboard: [ue]
Blocks: 160730
This is no longer a problem... was taken care of in bug 171236. 
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
verified wroksforme
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: