82207 - Complete MSAA XUL support

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Chad Austin]

Reproducible:  Always

Steps to reproduce:
1) Download MSAA SDK
2) Run Inspect Objects
3) Open Mozilla preferences dialog box
3) Select home page location edit box

Actual behavior:

The name, value, and role of the object according to the Inspector are none,
none, and client, respectively.

Expected behavior:

Name, value, and role should be "Location", "<whatever URL>", and "editable
text", respectively.

Forms within web pages (and throughout the rest of chrome) have similar behavior
and should be updated to return meaningful values.

Comment 1

[John Morrison]

We should probably get a testing plan in order, and in line with requirements.

Comment 2

[Aaron Leventhal]

Aegis,

We only have MSAA working for HTML at the moment.
XUL is coming next.
Thanks for filing a bug for us :)

Aaron

Comment 3

[Chad Austin]

QA contact -> dsirnapalli

Comment 4

[Aaron Leventhal]

*** Bug 96115 has been marked as a duplicate of this bug. ***

Comment 5

[John Gaunt (redfive)]

Attachment: initial diff for xul accessibility

Comment 6

[John Gaunt (redfive)]

Attachment: zip file of 4 new files for xul acccessibility -- nsIAccessibleProvider.idl and 3 XUL element idl files

Comment 7

[Aaron Leventhal]

In xpfe\global\resources\content\bindings\checkbox.xml
 (*NOT* checkboxBindings.xml)

- <implementation>
+ <implementation implements="nsIDOMXULCheckboxElement, nsIAccessibleProvider">

==========================

However, it only seems to support the first interface under implements="i1, i2"

Comment 8

[Aaron Leventhal]

Yep, I have it working now - as long we don't list 2 interfaces in the
implementation="i1, i2" part.

Comment 9

[David Hyatt]

Make sure you labeled both interfaces as scriptable in the IDL.

Comment 10

[Aaron Leventhal]

Attachment: checkbox working

Comment 11

[Aaron Leventhal]

The attachment "checkbox working" shows just that.

You also need the patch from 96610 for this to work, as well as the 4 .idl files
in the zip file attachment.

Don't forget your make depend after you add the new .idl files.

Comment 12

[Aaron Leventhal]

Attachment: Full patch with new .idl files -- ready for review

Comment 13

[Aaron Leventhal]

Dave,

John and I have gone over this. This patch is ready for your sr=

In nsIDOMXULControlElement.idl, we had to comment out some things in order to
compile.
They were already defined in the parent class.
+//  readonly attribute nsIControllers controllers;
+//  void focus();
+//  void blur();

Same thing in nsIDOMXULLabeledControlElement.idl
+//  void doCommand();

Finally, do you know if is there a better way to do this? It doesn't work when I
get rid of the second line.
var accService =
Components.classes["@mozilla.org/accessibilityService;1"].createInstance();
accService =
accService.QueryInterface(Components.interfaces.nsIAccessibilityService);
return (accService? accService.createXULCheckboxAccessible(this): null);

- Aaron

Comment 14

[Aaron Leventhal]

Dave, one more thing.

In the .idl files, I believe John had to change the interface names from XUL* to
nsIDOMXUL*

Is that okay?

Aaron

Comment 15

[John Gaunt (redfive)]

r=jgaunt for 46985,

we need clarification on a couple issues from hyatt -- outlined by aaron above

Comment 16

[David Hyatt]

You want getService rather than createInstance, don't you?

Comment 17

[Aaron Leventhal]

Attachment: New patch with getService instead of createInstance

Comment 18

[Aaron Leventhal]

So..... are we sr= worthy or not?

Comment 19

[David Hyatt]

Yes.  sr=hyatt.  Please hold off until 0.9.5 though.  Keep the methods in the
IDL commented out too.  I like that.  Thanks.

Comment 20

[David Hyatt]

There is an error in the spec.

tabindex

should be

tabIndex

In the IDL, you should make sure you use "tabIndex".

Comment 21

[John Gaunt (redfive)]

aaron: To improve the clarity and speed development I'd like to suggest the
following. Let's make this a tracking bug for all the individual XUL elements
and file individual bugs on them. This bug can handle any code that is used
across them all ( like nsIAccessibleProvider.idl ). We need to get that code in
right away to ease the process of developing the solutions for the different XUL
widgets.

There are going to be other dependancies ( like bug 96019 for radios ) dealing
with the implementation of the XUL 1.0 spec as well, and these may ( like radios
) be different for the different XUL elements.

Comment 22

[Aaron Leventhal]

Attachment: tabindex is now tabIndex

Comment 23

[Aaron Leventhal]

I'm going to check in these changes under this bug, and keep it open as a
tracking bug for other XUL widgets.

Comment 24

[Aaron Leventhal]

Changes necessary to build on Mac:

The file name nsIDOMXULLabeledControlElement.idl has been changed to
nsIDOMXULLabeledControlEl.idl because file names must be <31 chars long for Mac.

Also, these files need to be added to the Mac IDL project.
/dom/public/idl/xul/:
nsIDOMXULCheckboxElement.idl
nsIDOMXULControlElement.idl
nsIDOMXULLabeledControlEl.idl

/accessible/public
nsIAccessibleProvider.idl

Comment 25

[Aaron Leventhal]

Attachment: nsIDOMXULLabeledControlElement.idl -> nsIDOMXULLabeledControlEl.idl

Comment 26

[Aaron Leventhal]

*** Bug 110699 has been marked as a duplicate of this bug. ***

Comment 27

[Aaron Leventhal]

Attachment: Fixes bugs 109851, 108629, 109921, 109977, 109153, 109187, 109213, 109221

Comment 28

[Aaron Leventhal]

Attachment: Try #2 (has new files) - Fixes bugs 109851, 108629, 109921, 109977, 109153, 109187, 109213, 109221

Comment 29

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 30

[saari (gone)]

Please nominate the individual bugs that are getting fixed, not the meta bugs.
This should also go on the landing page for tracking

Comment 31

[Aaron Leventhal]

Progress report: we now have all of the XUL MSAA support necessary to make
Mozilla or Netscape accessible. Bug reports welcome.

Comment 32

[Aaron Leventhal]

This meta bug is no longer useful since we basically have XUL MSAA support
working other than a few flaws, which are filed in indivual bugs.