826703 - Convert CDATA sections and processing instructions to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

If we do that, we can nix so hasXPConnectImpls bits.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Rename nsXMLCDATASection to mozilla::dom::CDATASection.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Convert CDATASection to WebIDL.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Rename nsXMLProcessingInstruction to mozilla::dom::ProcessingInstruction.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Convert ProcessingInstruction to WebIDL.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 697938 [details] [diff] [review]
part 3.  Rename nsXMLProcessingInstruction to mozilla::dom::ProcessingInstruction.

Review of attachment 697938 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/xml/content/src/nsXMLProcessingInstruction.cpp
@@ +141,1 @@
>                                          bool aDumpAll) const

Indentation

::: content/xml/content/src/nsXMLProcessingInstruction.h
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef mozilla_dom_XMLProcessingInstruction_h
> +#define mozilla_dom_XMLProcessingInstruction_h

Drop the XML

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed those nits.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 4 with the unexpected passes fixed

Comment 8

[Boris Zbarsky [:bzbarsky]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/fe88a7f31340
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f9288409f219
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/0af1ffafa95d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/279436817e2a

Comment 9

[Boris Zbarsky [:bzbarsky]]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 824823
User impact if declined: Probably expoitable, given bug 827468
Testing completed (on m-c, etc.): Green on inbound.
Risk to taking this patch (and alternatives if risky): I think this is low-risk.  The
   alternative is to back out the CharacterData and Text parts of bug 824823, which is
   probably just as much risk.
String or UUID changes made by this patch: None.

Note: Private comment, since nothing else here indicates any sort of security thing....

Comment 10

[Boris Zbarsky [:bzbarsky]]

Aand just closing this up, since bug 827468 just got marked sec-sensitive.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fe88a7f31340
https://hg.mozilla.org/mozilla-central/rev/f9288409f219
https://hg.mozilla.org/mozilla-central/rev/0af1ffafa95d
https://hg.mozilla.org/mozilla-central/rev/279436817e2a

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 697936 [details] [diff] [review]
part 1.  Rename nsXMLCDATASection to mozilla::dom::CDATASection.

Approving on aurora considering it is sec-crit & the back-out of the regression is equally risky.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5f28703e70fd
https://hg.mozilla.org/releases/mozilla-aurora/rev/cb1db956f12b
https://hg.mozilla.org/releases/mozilla-aurora/rev/e2804d339fdd
https://hg.mozilla.org/releases/mozilla-aurora/rev/a61bee78cb46