827268 - Avoid useless onVisit work on the transition filtered queries

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

if we get an onVisit notification in a query filtering by transition, we can avoid doing anything if the transitions don't match.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

this should solve the hangs when navigating with the Library Downloads view open.

The live update is already tested in test_transitions.js

Comment 2

[Asaf Romano (gone)]

What was the reason transition-queries were made COMPLEX in the first place?

Comment 3

[Marco Bonardo [:mak]]

(In reply to Mano from comment #2)
> What was the reason transition-queries were made COMPLEX in the first place?

When Mehdi implemented that filter EvaluateQueryForNode was unpolished and in a somehow bogus state (I think we also still had the old and heavy FilterResultSet implementation), my recent cleanups in that method for hidden and frecency made clear we could support more simple results updating, indeed it should have not been complex in the first place, but at that time was easier to do ("just refresh and everything will work").

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33b1a42588c2

should be ported to Aurora.

Comment 5

[Ed Morley [:emorley]]

Backed out for breaking xpcshell:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=30ec18652409&jobname=xpcshell
(is push after since yours got coalesced)

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7947681f3fa

Please consider using Try if possible :-)

Comment 6

[Marco Bonardo [:mak]]

interesting, I ran all tests locally before pushing, wonder what happened

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch v1.1

the usual last minute change, let's avoid assigning -1 to an uint!

Comment 8

[Marco Bonardo [:mak]]

https://tbpl.mozilla.org/?tree=Try&rev=02e43b34326c

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63cbf8539eac

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/63cbf8539eac

Comment 11

[Marco Bonardo [:mak]]

Comment on attachment 699265 [details] [diff] [review]
patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: Performance issues
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): involves just the download query
String or UUID changes made by this patch: none

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f5e3e40ab3c9