832060 - Make generation of language pack's install.rdf only generate valid xml

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #591783 +++

I'm not sure if this is the same issue as before, but there are still several language packs being generated with corrupt install.rdf files due to whitespace before the <?xml?> declaration:

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/ar.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/bn-BD.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/ca.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/csb.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/fa.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/ff.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/gd.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/18.0/win32/xpi/nso.xpi

Comment 3

[Kris Maglione [:kmag]]

Unduping this, since this is still happening for the above language packs in the 19 builds, and the fix for the duped bug had nothing to do with any of these other than fa.xpi

Comment 4

[Toni Hermoso Pulido]

This seems to be fixed for ca langpack: bug 829246, unless I'm missing something.

ftp://ftp.mozilla.org/pub/firefox/releases/19.0/win32/xpi/ca.xpi

Comment 5

[Kris Maglione [:kmag]]

It looks like most of these are now fixed. The only ones I see that still have issues are:

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/19.0-candidates/build1/win32/xpi/csb.xpi
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/19.0-candidates/build1/win32/xpi/nso.xpi

Comment 6

[Toni Hermoso Pulido]

Will corrected langpacks be included in next batch? Otherwise I will reopen bug 485617.

Comment 7

[Kris Maglione [:kmag]]

The csb and nso language packs still have malformed install.rdf files in 20.0.

Comment 8

[Jan Horak [:jhorak]]

Yes, we've hit malformed csb langpack in 17.0.6 ESR update.

Comment 9

[Kris Maglione [:kmag]]

This is the third release in a row where I've had to manually fix these language packs to upload them to AMO. The ones on FTP are still broken.

Comment 10

[Jan Horak [:jhorak]]

The csb langpack in 17.0.7 ESR seems to be good. Thanks.

Comment 11

[Axel Hecht [:Pike]]

(In reply to jhorak from comment #10)
> The csb langpack in 17.0.7 ESR seems to be good. Thanks.

That's actually concerning, because we shouldn't take changes to ESR for l10n.

Bhavana, can you check what went into 17.0.7 l10n-wise, notably for csb?

Comment 12

[Kris Maglione [:kmag]]

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/17.0.7esr/win32/xpi/csb.xpi seems to still be broken for me.

Comment 13

[bhavana bajaj [:bajaj]]

(In reply to Axel Hecht [:Pike] from comment #11)
> (In reply to jhorak from comment #10)
> > The csb langpack in 17.0.7 ESR seems to be good. Thanks.
> 
> That's actually concerning, because we shouldn't take changes to ESR for
> l10n.
> 
> Bhavana, can you check what went into 17.0.7 l10n-wise, notably for csb?

Given comment 12, I don't think there is an outstanding question for me here.Nevertheless, for reference this is the list of bugs that went in 17.0.7 esr http://mzl.la/17KyUA5, I glanced at it and did not see anything out of ordinary that we tool 110n wise

Comment 14

[Kris Maglione [:kmag]]

csb.xpi and bg.xpi are still broken in 23.0.

Comment 15

[Kris Maglione [:kmag]]

Yet again for 24.0. Can we apply the same fix from bug 833343 to these?

Comment 16

[(no longer active)]

(In reply to Kris Maglione [:kmag] from comment #15)
> Yet again for 24.0. Can we apply the same fix from bug 833343 to these?

I'm not sure.

Comment 17

[Jorge Villalobos [:jorgev] (he/him)]

Axel, this keeps happening for every release. Who can look into this bug? Comment #15 mentions a potential solution, but we don't know who can help us corroborate it and fix this bug.

Comment 18

[Axel Hecht [:Pike]]

Let's reshape this bug. I'm torn if that's useful with this bug, but whichever.

The only "fix" is to make the build system check the XML, and do "something" if the localized RDF/XML is not valid xml.

Apart from that, this bug isn't really actionable, IMHO.

Comment 20

[Kris Maglione [:kmag]]

The issue in csb.xpi seems, as far as I can tell, to be a blank line at the end of langpack/toolkit/defines.inc

I have no idea what the problem with bg.xpi is

Comment 21

[Kris Maglione [:kmag]]

I don't know why no-one seems to care about this, or why it seems to have become my job to manually repair these two language packs for every release, but I'm washing my hands of it. Combined, the bg and csb language packs have about 15,000 users. Unless the builds for these are fixed, these users will no longer receive updates for new releases.

Comment 22

[Axel Hecht [:Pike]]

bg should be fixed in the next cycle, and we're removing csb from the builds, too. This should fix itself in the next cycle.

Not that it's more reliable, just the symptoms fade away.

Comment 23

[Francesco Lodolo [:flod]]

Assuming this is done, and we also switched to manifest.json for language packs.