83944 - urlbar history popup should have a max-width

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[John Morrison]

I often wind up reloading url's that are long GET queries, by hitting return
in the urlbar. This adds them to my history list. 

The problem is that the popup has an unconstrained width, so the popup that 
comes up is as wide as my monitor (but it isn't really that useful to be able
to see that information in the query string).

It seems like a simple rule, such as:

  #ubhist-popup {
    max-width : 40em;
  }

would be good to add to the skins. It seems to work well for me [it limits it 
to 40em if the urlbar is less than 40em wide, and otherwise it keeps the popup
as no greater than the width of the urlbar].

I'll attach an image of the uselessly wide popup that I often get. It seems to 
me that this fits the 'low-risk', 'clear benefit' criteria. Whaddya think?

Comment 1

[John Morrison]

Attachment: uber-wide urlbar history popup must die!

Comment 2

[doctor__j]

Will it solve the problem in bug 83457 ??

Comment 3

[gary_Cope]

*** Bug 83237 has been marked as a duplicate of this bug. ***

Comment 4

[John Morrison]

*** Bug 90811 has been marked as a duplicate of this bug. ***

Comment 5

[Aaron Kaluszka]

*** Bug 94697 has been marked as a duplicate of this bug. ***

Comment 6

[Matthias Versen [:Matti]]

*** Bug 97331 has been marked as a duplicate of this bug. ***

Comment 7

[Shotaro Kamio]

*** Bug 107725 has been marked as a duplicate of this bug. ***

Comment 8

[Thomas Swan]

Why can't it find the width of its parent?  

It's finding a max width of {screen width} already.  This would let you resize
the window and the URL bar with minimal effect.

Comment 9

[Joe Hewitt (gone)]

Attachment: patch

This popup actually did have a max-width - it has the sizetopopup attribute
set, which is supposed to instruct it to be no wider than the urlbar textbox. 
However, as I discovered, sizetopopup will only change the size of a popup if
it has to grow it - if it needs to shrink it, it won't.  I think this is the
wrong behavior, and so, this patch allows sizetopopup to shrink as well.

Comment 10

[Joe Hewitt (gone)]

fixed

Comment 11

[Patty Mac]

Verified the patch.