844929 - Accept numeric parameters > UINT_MAX in SDP o-lines

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Allow SDP session ids > MAX_UINT

Comment 2

[Eric Rescorla (:ekr)]

Attachment: Allow SDP session ids > MAX_UINT

Comment 3

[Eric Rescorla (:ekr)]

Attachment: Allow SDP session ids > MAX_UINT

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 718003 [details] [diff] [review]
Allow SDP session ids > MAX_UINT

Review of attachment 718003 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/core/sdp/sdp_token.c
@@ +65,5 @@
> +
> +    if (ptr[end] == '\0')
> +	return SDP_SUCCESS;
> +
> +    return SDP_INVALID_PARAMETER;

The spec says this:

The numeric value of the session id
   and version in the o line MUST be representable with a 64 bit signed
   integer.  The initial value of the version MUST be less than
   (2**62)-1, to avoid rollovers.

Should we be doing a strtoul instead and checking against this max value here?

Comment 5

[Timothy B. Terriberry (:derf)]

(In reply to Ethan Hugg [:ehugg] from comment #4)
> Should we be doing a strtoul instead and checking against this max value
> here?

A long is 32 bits on Windows. That is one of the many problems this patch is fixing. I'm not against being stricter in what we accept, but it would probably mean writing our own string->int64 function (not that this is difficult, since we don't really care about speed).

Comment 6

[Eric Rescorla (:ekr)]

Since this is SIPCC, we can use PR_sscanf, which seems to support PRUint64.

Can you take this?

Comment 7

[Ethan Hugg [:ehugg]]

Attachment: Accept numeric parameters > UINT_MAX in SDP o-lines

Comment 8

[Eric Rescorla (:ekr)]

Comment on attachment 718495 [details] [diff] [review]
Accept numeric parameters > UINT_MAX in SDP o-lines

Review of attachment 718495 [details] [diff] [review]:
-----------------------------------------------------------------

Would it make sense to make these strings by string concatenation so we don't have so much cut-and-paste.

Comment 9

[Ethan Hugg [:ehugg]]

Attachment: Accept numeric parameters > UINT_MAX in SDP o-lines

Comment 10

[Ethan Hugg [:ehugg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1d01526d344

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a1d01526d344