Closed Bug 850332 Opened 11 years ago Closed 11 years ago

Use jemalloc inside mozglue

Categories

(Core :: mozglue, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

mozglue currently uses the system allocator on Android. It would be better for it to use jemalloc, especially to make things easier for bug 828845.
Attached patch Use jemalloc inside mozglue (obsolete) — Splinter Review
Attachment #724082 - Flags: review?(bugmail.mozilla)
Comment on attachment 724082 [details] [diff] [review]
Use jemalloc inside mozglue

I need to find something better than using the system allocator for the pthread_atfork deadlock, because b2g will have the same problem when bug 850576 is fixed, and using the system allocator won't work there.
Attachment #724082 - Flags: review?(bugmail.mozilla)
Blocks: 850576
Attachment #724393 - Flags: review?(bugmail.mozilla)
Attachment #724082 - Attachment is obsolete: true
Comment on attachment 724393 [details] [diff] [review]
Use jemalloc inside mozglue

Review of attachment 724393 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delayed review, I had to learn a bunch of stuff before I could review this :) It looks ok to me but I'm not really confident in my review, if you want more meaningful feedback you might want to get somebody else to review it as well.
Attachment #724393 - Flags: review?(bugmail.mozilla) → review+
Attachment #724393 - Flags: review?(mwu)
Comment on attachment 724393 [details] [diff] [review]
Use jemalloc inside mozglue

Oh, interesting deadlock.

Well, the implementation looks fine for what it's doing, and I can't think of anything better to do here.. glibc looks like it statically allocates 48 entries and then switches to calloc when out of entries, which is just a more complicated version of this.
Attachment #724393 - Flags: review?(mwu) → review+
glandium, mwu,
  could this bug explain the android failures we are seeing in bug 761987?
Depends on: 861973
https://hg.mozilla.org/mozilla-central/rev/65a8f7db2648
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Depends on: 865106
(In reply to Doug Turner (:dougt) from comment #8)
> glandium, mwu,
>   could this bug explain the android failures we are seeing in bug 761987?

It doesn't look like this fix had any effect on the rate of occurrence of the crash:
http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=761987&startday=2013-03-18&endday=2013-05-02&tree=trunk

Note that the trend down to zero is believed to be that the bug was masquerading as other Android intermittent issues, not that it had been fixed.
Depends on: 911914
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: