Closed
Bug 86740
Opened 23 years ago
Closed 22 years ago
Mac windows automatically grow by 1 pixel (both v and h) for a click and release in the grow area
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.0.1
People
(Reporter: scc, Assigned: mikepinkerton)
References
Details
Attachments
(1 file)
1.00 KB,
patch
|
mikepinkerton
:
review+
bugzilla
:
superreview+
jud
:
approval+
|
Details | Diff | Splinter Review |
click and release (without moving the mouse) in the grow box of Mac window expected behavior: grow outline should draw, then go away no change should occur in layout actual behavior window grows by 1 pixel horizontally and vertically page reflows
Comment 3•23 years ago
|
||
Sounds like this is being caused by some code that pierre put in to fix an older bug.
Comment 4•23 years ago
|
||
Related to bug 6988 and bug 12672. See my comments from [1999-10-11 16:12] in bug 6988.
Comment 6•23 years ago
|
||
May God have mercy on us all. The 212 bug spam-o-rama is Now!
QA Contact: aegis → jrgm
Updated•22 years ago
|
Assignee | ||
Comment 9•22 years ago
|
||
the +1's are from the fix for bug 6988. in what cases do we still need them? only on os9?
Comment 10•22 years ago
|
||
In comment number 6 from bug 6988 it says it would entitle moving the live-resizing code from nsMacMessagePump to nsMacWindow. This has been done. It may still need those +1's in OS 9, I doubt it does, but I haven't checked. Also with BoundsChanged events calling SizeWindow, which is the root cause of this bug, is not necessary. As long as the variables for the size passed to it are not changed from the current window size the Resize function does not call SizeWindow, luckily. When the +1's were there it was calling SizeWindow. If there is a problem on OS9 then there is a discrepancy with the window bounds reported to us, though apple probably won't fix something that small, so maybe it would be wise to make Resize also accept zeros to not call SizeWindow. Furthermore, this is probably a CarbonLib bug also. kEventWindowBoundsChanged should not be sent at the same time as kEventWindowResizeComplete (unless on OS 9), BoundsChanged should only be sent if the bounds really do change(which would be the case on OS 9). Anybody want to submit this to apple's radar website?
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla1.0.1
Assignee | ||
Comment 11•22 years ago
|
||
*** Bug 132507 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 12•22 years ago
|
||
Comment on attachment 83936 [details] [diff] [review] Bug patch... r=pink i tried this on os9 and it seems the behavior we were trying to correct has gone away.
Attachment #83936 -
Flags: review+
Updated•22 years ago
|
Attachment #83936 -
Flags: superreview+
Comment 13•22 years ago
|
||
Comment on attachment 83936 [details] [diff] [review] Bug patch... rs=blake
Assignee | ||
Comment 14•22 years ago
|
||
landed on trunk. requesting branch approval. this is a very simple fix to take that fixes an annoying polish quirk.
Keywords: adt1.0.0
Assignee | ||
Updated•22 years ago
|
Whiteboard: [needs a=, drivers mailed 5/29]
Updated•22 years ago
|
Attachment #83936 -
Flags: approval+
Comment 15•22 years ago
|
||
please land on the 1.0.1 branch ASAP. once landed, please remove the mozilla1.0.1+ keyword and add the fixed1.0.1 keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
Comment 16•22 years ago
|
||
adding adt1.0.1+. Please check into the 1.0 branch as soon as possible.
Assignee | ||
Comment 17•22 years ago
|
||
landed on trunk and branch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•22 years ago
|
Keywords: adt1.0.1+ → fixed1.0.1
Keywords: mozilla1.0.1+,
review
Whiteboard: [needs a=, drivers mailed 5/29][adt2 rtm]
You need to log in
before you can comment on or make changes to this bug.
Description
•