Closed Bug 872087 Opened 12 years ago Closed 12 years ago

move HOST_LIBRARY_NAME to moz.build

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: joey, Assigned: jarmstrong)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

move HOST_LIBRARY_NAME to mozbuild (file batch #1)
9.29 KB, patch
mshal
: review+
Details | Diff | Splinter Review
move HOST_LIBRARY_NAME to mozbuild (python/mozbuild logic)
5.12 KB, patch
ted
: review+
Details | Diff | Splinter Review
mozbuild HOST_LIBRARY_NAME conversion cleanup.
6.48 KB, patch
gps
: review+
Details | Diff | Splinter Review
./build/unix/stdc++compat/Makefile.in ./modules/libbz2/src/Makefile.in ./modules/libmar/src/Makefile.in ./toolkit/crashreporter/google-breakpad/src/common/dwarf/Makefile.in ./toolkit/crashreporter/google-breakpad/src/common/linux/Makefile.in ./toolkit/crashreporter/google-breakpad/src/common/mac/Makefile.in ./toolkit/crashreporter/google-breakpad/src/common/Makefile.in ./toolkit/crashreporter/google-breakpad/src/common/solaris/Makefile.in
Assignee: nobody → joey
Comment on attachment 757937 [details] [diff] [review] move HOST_LIBRARY to moz.build (logic) Add HOST_LIBRARY as a pass through variable.
Attachment #757937 - Flags: review?(ted)
Attachment #757937 - Flags: review?(ted)
Summary: move HOST_LIBRARY to moz.build → move HOST_LIBRARY_NAME to moz.build
Local build verified, try results pending.
Attachment #758160 - Flags: review?(mshal)
Add HOST_LIBRARY_NAME as a pass-through variable.
Attachment #757937 - Attachment is obsolete: true
Attachment #758163 - Flags: review?(ted)
Comment on attachment 758160 [details] [diff] [review] move HOST_LIBRARY_NAME to mozbuild (file batch #1) Looks pretty straightforward!
Attachment #758160 - Flags: review?(mshal) → review+
Comment on attachment 758160 [details] [diff] [review] move HOST_LIBRARY_NAME to mozbuild (file batch #1) Try job: https://tbpl.mozilla.org/?tree=Try&rev=1710525a0e25
Attachment #758163 - Flags: review?(ted) → review+
Comment on attachment 758163 [details] [diff] [review] move HOST_LIBRARY_NAME to mozbuild (python/mozbuild logic) inbound push https://hg.mozilla.org/integration/mozilla-inbound/rev/f9f7ba08df90
https://hg.mozilla.org/mozilla-central/rev/f9f7ba08df90
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Need to reopen, [leave open] whiteboard tag was omitted from the bug and still need an inbound push for the makefile edits.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 758160 [details] [diff] [review] move HOST_LIBRARY_NAME to mozbuild (file batch #1) Try job: https://tbpl.mozilla.org/?tree=Try&rev=1710525a0e25 Inbound push: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d80bc37c23d3 committed changeset 134520:d80bc37c23d3
https://hg.mozilla.org/mozilla-central/rev/d80bc37c23d3
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Assignee: joey → jarmstrong
Comment on attachment 764116 [details] [diff] [review] mozbuild HOST_LIBRARY_NAME conversion cleanup. It has been a week, time to cleanup behind the conversion. Added HOST_LIBRARY_NAME to the invalid makefile variable list.
Attachment #764116 - Flags: review?(gps)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #764116 - Flags: review?(gps) → review+
Comment on attachment 764116 [details] [diff] [review] mozbuild HOST_LIBRARY_NAME conversion cleanup. Pushed to inbound: committed changeset 135591:5458a7880db5 https://hg.mozilla.org/integration/mozilla-inbound/rev/5458a7880db5
https://hg.mozilla.org/mozilla-central/rev/5458a7880db5
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: