Closed
Bug 875294
Opened 11 years ago
Closed 11 years ago
Implement menclose notation "updiagonalarrow"
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: fredw, Assigned: fredw)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(2 files, 1 obsolete file)
1.24 KB,
text/html
|
Details | |
11.80 KB,
patch
|
Details | Diff | Splinter Review |
In order to implement the \cancelto command MathJax uses the nonstandard syntax <menclose notation="updiagonalstrike" class="MJX-arrow"> and render it as an up "diagonal arrow". Unfortunately other MathML rendering engines won't draw the arrow head. I suggested to replace that by a new notation "updiagonalarrow" (the list of menclose notation is open-ended). I think it would be good to implement this notation in Gecko. Note that MathJax will actually generate <menclose notation="updiagonalstrike updiagonalarrow"> for backwards compatibility with rendering engines that only support "updiagonalstrike". So Gecko should make "updiagonalarrow" override "updiagonalstrike".
Comment 1•11 years ago
|
||
(In reply to Frédéric Wang (:fredw) from comment #0) > So Gecko should make "updiagonalarrow" override "updiagonalstrike". If the arrow is drawn such that its shaft is the same as the strike, then no special case is required when the two occur together. MathML notations are usually all drawn iirc.
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #1) > If the arrow is drawn such that its shaft is the same as the strike, then no > special case is required when the two occur together. MathML notations are > usually all drawn iirc. Yes, I agree. I think I was more thinking about how menclose is handled in MathJax. That should not be a problem in Gecko.
Assignee | ||
Comment 3•11 years ago
|
||
Here is a test case. See also attachment 389368 [details] for a dynamic version where you can select the dimensions and notations.
Assignee | ||
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4a3d43b50185
Assignee | ||
Updated•11 years ago
|
Attachment #756937 -
Flags: review?(karlt)
Comment 5•11 years ago
|
||
Comment on attachment 756937 [details] [diff] [review] Patch V1 >+ rect.TopRight(), >+ rect.TopRight() + gfxPoint(-w -.4*h, h - .4*w), For a wide rect, this point may be more than e/2 above the top of rect, which can lead to parts not being invalidated correctly, on scrolling or selection, for example.
Attachment #756937 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 6•11 years ago
|
||
OK, I modified the patch to limit the overflow by a maximum of e/2. That preserves the shape of the arrow head in normal cases and that seems to be what MathJax HTML-CSS does too (but only for the y coordinates??).
Attachment #756937 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed,
dev-doc-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc78a3d303c8
Flags: in-testsuite+
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc78a3d303c8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Assignee | ||
Comment 9•11 years ago
|
||
As I indicated on the MathJax issue, this does not work very well in RTL. See also discussion on the LaTeXML mailing list: http://lists.jacobs-university.de/pipermail/project-latexml/2013-June/001379.html
Comment 10•11 years ago
|
||
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/menclose https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/24#MathML
Keywords: dev-doc-needed → dev-doc-complete
Updated•10 years ago
|
Depends on: CVE-2014-1508
You need to log in
before you can comment on or make changes to this bug.
Description
•