877560 - B2G RIL: support EF_CBMID (Data Download via SMS-CB)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Gecko reads CBMI & CBMIR since bug 778093 and CBMID is necessary for receiving Class-2 CB messages.

See 3GPP TS 31.102 section 5.4.3 "Data Download via SMS-CB" for USIM and 3GPP TS 51.011 section 11.6.11 "Data Download via SMS-CB" for SIM.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github PR for platform/external/qemu

Add default CBMIR entries.

Comment 3

[Michael Schwartz [:m4]]

Handled internally by modem and part of Qualcomm's release.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Michael Schwartz [:m4] from comment #3)
> Handled internally by modem and part of Qualcomm's release.

Please note Qualcomm's RIL is not the only RIL implementation on B2G.  Close only your own bug!

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 756653 [details] [diff] [review]
patch

With PR for external/qemu, we should see following lines in logcat:

  CBMID: [49153,49154,61441,61442]
  Cell Broadcast search lists: {"MMI":null,"CBMI":[45056,45057,61440,61441],"CBMID":[49153,49154,61441,61442],"CBMIR":[45058,49153,     61442,65281]}
  Cell Broadcast search lists(merged): [45056,45057,45058,49154,61440,65281]

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 756653 [details] [diff] [review]
patch

Review of attachment 756653 [details] [diff] [review]:
-----------------------------------------------------------------

Mostly looks good, except for the 'which' pamameter, which I think is redudant.

::: dom/system/gonk/ril_worker.js
@@ +4146,5 @@
>     * Merge all members of cellBroadcastConfigs into mergedCellBroadcastConfig.
>     */
>    _mergeAllCellBroadcastConfigs: function _mergeAllCellBroadcastConfigs() {
>      if (!("CBMI" in this.cellBroadcastConfigs)
> +        || !("CBMID" in this.cellBroadcastConfigs)

The position of '||' seems better if we move to the end of line.

@@ +10742,5 @@
>      ICCIOHelper.loadTransparentEF({fileId: ICC_EF_SPDI,
>                                     callback: callback.bind(this)});
>    },
>  
> +  _readCbmiHelper: function _readCbmiHelper(fileId, which) {

'which' sounds unnecessary to me,
you should do the mapping(fileId -> name) inside this function

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch v2

Address previous review comment.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Gecko:  https://hg.mozilla.org/projects/birch/rev/b61efdb1d7b8
GitHub: https://github.com/mozilla-b2g/platform_external_qemu/commit/231d2bbdb5ce5d855e50333e4dc9ada0fdbec25d

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b61efdb1d7b8