88553 - text before a after input field in master password timeout in not aligned

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Henrik Gemal]

In the prefs -> Privacy -> Master Password
The text before the text input field and after is not aligned.

It looks like:
                                       minutes or longer"
"If it has not been used for [      ]

build 20010629 on win2k

Comment 1

[(Don't use, old account) - Kai Engert]

Looks unaligned on Linux too.

-> Kai

Comment 2

[(Don't use, old account) - Kai Engert]

Attachment: Patch to fix layout, see comment

Comment 3

[(Don't use, old account) - Kai Engert]

The reason why this is not aligned: A combination of radio button and text label
is used. And these two types are not aligned with each other. There seems to be
no simple way (like using align="bottom") to get them aligned.

I suggest to use a trick to make them aligned: Use radio buttons without text,
and put separate text labels to the right of the radio buttons. This way all
text labels are aligned.

By default the text label appears not in the middle of the radio bullet, but
somewhat higher. I added a margin and hope, this works on other platforms, too
(I tested on Linux only).

The width of the radio button needs to be reduced, as by default there is a huge
gap between the radio bullet and the text label.
Before we check this in, we should ask testers using other platforms if it looks
okay there, too.

Comment 4

[(Don't use, old account) - Kai Engert]

David, please review.

Comment 5

[David P. Drinan]

r=ddrinan.

Comment 6

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 7

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 8

[Henrik Gemal]

also just needs checkin...

Comment 9

[John Unruh]

Mass assigning QA to ckritzer.

Comment 10

[Javier Delgadillo]

Checked in patch for Kai.

Comment 11

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- MacOS91 2001-08-22-08-trunk (commercial)
- MacOS_X 2001-08-22-05-trunk (mozilla)
- LinRH62 2001-08-22-08-trunk (commercial)
- Win98SE 2001-08-22-06-trunk (commercial)

Comment 12

[Kai Engert (:KaiE:)]

Changing target to 2.1

Comment 13

[Kai Engert (:KaiE:)]

Really changing target to 2.1