88956 - Need to disable plugins in Composer (embedding)

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Simon Fraser [no longer active]]

We need to disable plugins in pages that you load in composer. Corrently, plugins 
load, and respond to click just like they do in a browser window, which is bad.

Comment 1

[sujay]

cc: shrir.

Comment 2

[Peter Lubczynski]

Aren't plugins disabled at the dochshell level?

Comment 3

[rubydoo123]

1.0

Comment 4

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I think you really want to use ShouldLoad, and disable the loading of
<object>/<applet>/<embed> elements for that window.  Disabling the load of the
plugin itself seems very much like the wrong thing.

There was a time when <object> and whatnot were all wired up for the content
policy hooks, though that may no longer be the case.  I know that at least
<style> rotted.

Comment 6

[Simon Fraser [no longer active]]

Pre-sabbatical bug triage.

Comment 7

[Simon Fraser [no longer active]]

Not my bag baby.

Comment 8

[Jesse Ruderman]

*** Bug 159596 has been marked as a duplicate of this bug. ***

Comment 9

[Kevin McCluskey (gone)]

Syd: Can someone on the composer team take a look at this one. Kin is
overloaded. Thanks.

Comment 10

[Kathleen :Brade]

*** Bug 174378 has been marked as a duplicate of this bug. ***

Comment 11

[Chris Nalls]

Plussing as per Topembed triage.

Comment 12

[Kathleen :Brade]

-->akkana

Comment 13

[Akkana Peck]

Thought I had a clever way of doing this through a few lines in editor.css, but
it didn't work out.  If I get some time I'll try again, but meanwhile since this
is topembed+ it had better go to someone who's still on the project.

Comment 14

[Simon Fraser [no longer active]]

There's a docshell API that can be used to do this. Look at nsIWebBrowserSetup.

Comment 15

[Peter Lubczynski]

Mail/news calls nsIDocShell::SetAllowPlugins.



You'll disable documents and images with the OBJECT tag, but maybe you could do
something like this w/CSS:

<style>
  applet, embed, object {
    display: none;
  }
</style>

Note that this will not work when bug 90268 is fixed.

Comment 16

[Kathleen :Brade]

-->brade

Comment 17

[Kathleen :Brade]

Resolving this as fixed to get some QA cycles (partial if not complete fix was
checked in as part of bug 186054).

I need to know what the remaining issues are so we can enumerate them or file
new bugs if that is preferable.

Sujay--please test this on all platforms and with a variety of plugins (flash,
quicktime, java, etc)

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.02.19 --plugin content isn't loaded in composer.