Closed Bug 89404 Opened 23 years ago Closed 22 years ago

"get all new messages" should never be disabled

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.3alpha

People

(Reporter: pedro.lopes, Assigned: sspitzer)

References

Details

Attachments

(1 file, 1 obsolete file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.2+)
Gecko/20010704
BuildID:    2001070404

When "Local Folders" or any of its subfolders is selected the "Get All
New Messages" is grayed out, both in the toolbar pop-down button and 
the File menu. 



Reproducible: Always
Steps to Reproduce:
1. In the "mail folders" pane select "Local Folders" or any of its subfolders.
2. Try to select "Get All New Messages" from the toolbar or menu.

Actual Results:  The option is disabled.

Expected Results:  This operation should always be possible, it does not make
sense to disable it. This way the user has to select another folder before he
can get the new messages.
Confirming on Build 2001-07-14-08, Win2k

Since there is no other action on this bug, I will accept it as NEW but change
summary and severity to reflect "enhancement."

Pedro: In the meantime, try to see if this is a duplicate of another bug.  I
will be looking as well.
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: "get all new messages" should never be disabled → [RFE] "get all new messages" should never be disabled
Sigh, I hate forgetting things.  Adding myself to CC list.
Confirming on build 2001-08-06-08, Linux.
Can somebody change OS to "All"?
OS -> All
OS: Windows 2000 → All
Many people have multiple email accounts, and it "bothers" me that i always have
to select an account to get all mails/any mails, cos i purge all my mails to
"local folders" via filter.
I hope to see this "bug" fixed prior to moz 1.0 cos this is really no new
feature (should take modification of less then three lines of code, i guess).

Additionally, i would like to default the "get msgs" button to receive mail for
all accounts and let the drop down menu to receive for single accounts only;
this is the beahviour of outlook and really makes sense.

using mozilla 0.96 under Debian GNU/Linux (sid), but matters all platforms of
course.

greetings, Timo Boewing
I agree with Timo 100% -- it is inconvenient for folks with multiple accounts
especially, who have filters set up to automagically move things to offline
folders, to have to highlight another area just to get mail. And the "get msgs"
button should default to getting ALL accounts, with the submenu being to get
specific accounts (the opposite of the current "get msgs" button/submenu behavior)
I am surprised to find that this bug report is set as a request for enhancement,
I had always thought that it was a long standing Mozilla bug and I am not the
only one who thinks so since it is even referenced in a popular NS7 Faq :

http://techaholic.net/ns7.html#051


# Why does the Get Msgs button gray out in Mail and News at times?

I cannot answer the question as this is a bug in Netscape 7 PR1. However, I can
provide you a known pattern to cause this problem to occur. At this time this is
the only pattern I know about that causes this problem:

    * If you click on Local Folders, any of the mail folders in the Local
Folders, or any of the News account names, the Get Msgs button immediately grays
out.
    * Click on any mail folder or folders including subscribed newsgroups and
news server account names, the Get Msgs button remains grayed out.
    * Now click on any of the Mail account names. The Get Msgs button is no
longer grayed out -- its now a clickable button.

------

I think that this should be fixed to behave the way people expect it to work
(see Nathaniel's post). I mean, if _we_ Mozilla and NS7 power-users don't
understand the logic behind this, how can we expect normal users to accept this
as a feature and not as a hightly visible bug ?


Severity: enhancement → normal
Summary: [RFE] "get all new messages" should never be disabled → "get all new messages" should never be disabled
accepting.

today is "fix get msg button problems" day.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3alpha
I'm going to make it so if local folder is selected, get msgs (and get all new
messages) works.

get msgs will just get the msgs on the default account, which is what you'd
expect if you had a single account.
sounds good.
SS - "get msgs will just get the msgs on the default account, which is what you'd
expect if you had a single account."

? Not sure I understand this -- if you only have a single mail account, "get all
messages" would only get the default account anyways. But if you have more than
one account, It would seem to me that 99% of the time the user would want to
check them all, with checking individual accounts being the special-case
scenario. Outlook, OE, Poco, The Bat!, etc all default to checking all accounts
as standard behavior.
Attached patch always enable "get new messages" (obsolete) — Splinter Review
My first ever attempt at a Mozilla patch, so I'm probably way off the mark :-)
Oops, just getting used to Bugzilla - sorry, this comment should have been part
of the previous posting :-(

Anyway: I agree that checking *all* accounts should be the simpler, more
commonly used, default option.  Thus the "Get Msgs" toolbar button should check
all accounts, and probably the keyboard shortcuts (Ctrl-T and Ctrl-Shift-T)
should be swapped over too, so the more commonly used shortcut (get all
messages) is the simpler one (Ctrl-T).

Please go easy on my patch!  It *was* just for my personal gratification, but I
just wondered if it's even slightly like what is required here...
I agree with comment 11, both because getting all messages is the more common
action, and because it makes the UI more consistent (the button action should be
the same as the first entry in the popdown).
This might be better filed as separate bug though...
I've fixed this.

let's take the "what should the button do" discussion to another bug.

(see bug 125885)

I'll attach the patch.

Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Attached patch patchSplinter Review
Attachment #105552 - Attachment is obsolete: true
*** Bug 113874 has been marked as a duplicate of this bug. ***
+  // users don't like it when the "Get Msgs" button is enabled
+  // so let's never do that

That should probably be "disabled", not "enabled".
fixed the comment.  thanks for the heads up greg (and stephend).
Comment on attachment 105691 [details] [diff] [review]
patch

>+  var folders = new Array(1);
>+  folders[0] = folder;
>+
>   var compositeDataSource = GetCompositeDataSource("GetNewMessages");
>   GetNewMessages(folders, compositeDataSource);

Style nit:

var compositeDataSource = GetCompositeDataSource("GetNewMessages");
GetNewMessages([folder], compositeDataSource);
*** Bug 166061 has been marked as a duplicate of this bug. ***
*** Bug 137595 has been marked as a duplicate of this bug. ***
Using trunk builds 20021118 on winxp, macosx and linux whilce the Local Folder
is slected, clicking the Get Msg button Gets the message for the default mail
account and clicking the Get All New Msgs option on the Get Msg button gets all
new msgs for all logged in accounts.  
verified 
Status: RESOLVED → VERIFIED
Please can this fix be applied to the 1.2 branch? Its very annoying. I've
unpacked and patched my chrome for now, but it would be nice to not have to do
this once 1.2final is released.
*** Bug 181704 has been marked as a duplicate of this bug. ***
*** Bug 182516 has been marked as a duplicate of this bug. ***
Blocks: 164421
Product: Browser → Seamonkey
No longer blocks: 164421
Blocks: 158464
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: