898920 - Allow Savane (e.g. Savannah) See Also URLs

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[Simon Green]

Attachment: savane-v1.patch

You should be able to add a Savane URL in the See Also field. Savane powers Savannah, among other sites.

Comment 1

[Frédéric Buclin]

Comment on attachment 782335 [details] [diff] [review]
savane-v1.patch

>=== added file 'extensions/MoreBugUrl/lib/Savane.pm'

>+package Bugzilla::Extension::MoreBugUrl::Savane;
>+use strict;
>+use base qw(Bugzilla::BugUrl);

It doesn't pass tests. |use 5.10.1| is missing. Also use |use parent| instead of |use base|.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 782335 [details] [diff] [review]
savane-v1.patch

Review of attachment 782335 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
@@ +12,4 @@
>  <li>A ticket in an RT installation.</li>
>  <li>A topic on getsatisfaction.com.</li>
>  <li>A b[% %]ug on b[% %]ugs.php.net.</li>
> +<li>An bug in a Savane installation.</li>

Nit: "A bug"

Comment 3

[Simon Green]

Attachment: v2 patch

Make changes as suggested by LpSolit. Have filed bug 951426 about warnings that generate from runtests.pl unrelated to this change.

Comment 4

[Simon Green]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified extensions/MoreBugUrl/Extension.pm
modified extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
Committed revision 8903.                                                       

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
added extensions/MoreBugUrl/lib/Savane.pm
Committed revision 8904.