89932 - Privacy and Security preferences panel in classic inaccurate (click the triangle ...)

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[David Hallowell]

Recent versions of the Windows classic skin (also used on Linux and BeOS) now
use the windows convention of a [+] and [-] to expand lists and threads rather
than the triangle used in Modern and earlier versions of classic.

This makes the following information incorrect in the "Privacy and Security"
preferences panel: "If no subcategories are visible on the let under Privacy and
Security, click the triangle to expand the list."

This needs to be reworded in some manner in order to reflect the fact that this
widget could be anything depending on what the skin creator decides.

Comment 1

[sairuh (rarely reading bugmail)]

->psm folx.

Comment 2

[Stephane Saux]

-> kai
t->2.1

Comment 3

[(Don't use, old account) - Kai Engert]

Attachment: Changing to "double-click the entry"

Comment 4

[(Don't use, old account) - Kai Engert]

David, can you please review?

Comment 5

[David Hallowell]

I'm not an authorised Mozilla code reviewer but you can have an r= off me if you
want, but its value will be zero :)

If by review you just wanted my comments, I think the new wording is fine and
can't think of anything clearer myself (double clicking should always work, but
the widget to click on to expand is skin dependant so this seems the best
option). As for the change, it's not going to break anything so maybe a possible
consideration to check into the nsBranch (although not as important as NS6.x
defaults to modern).

There's no over David's on the Cc list so I thought I'd say that just in case
you thought as I was able to offer a code review, as for the best person to
review this I'm not sure, but as it involves a change to the wording in the user
interface it's probably a good idea to ask Matthew Thomas for his comments
before getting this checked in.

Comment 6

[(Don't use, old account) - Kai Engert]

David Hallowell, thanks for your comments! Indeed, there is no other David
currently in the CC list for this bug, I think I removed David Drinan from this
list by assigning the bug to myself and forget to add him to the CC list.

Stephane, do you want to review this, too?

Comment 7

[Stephane Saux]

r=ssaux
But cc'ing Sean Cotter.
Sean can you review.Thanks.

Comment 8

[Sean Cotter]

I would prefer "category" rather than "entry" in the enclosed patch. Slightly
easier to parse, since the beginning of the sentence talks about subcategories.

So with this change, the revised sentence reads as follows:

If no subcategories are visible on the left under Privacy and Security,
double-click the category to expand the list.

Comment 9

[(Don't use, old account) - Kai Engert]

Attachment: New patch

Comment 10

[(Don't use, old account) - Kai Engert]

Changing wording as requested.

Sean, can you please r= ?

Comment 11

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 12

[Sean Cotter]

r=cotter

Comment 13

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 14

[John Unruh]

Mass assigning QA to ckritzer.

Comment 15

[Javier Delgadillo]

checked in patch for Kai.

Comment 16

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- MacOS91 2001-08-22-08-trunk (commercial)
- MacOS_X 2001-08-22-05-trunk (mozilla)
- LinRH62 2001-08-22-08-trunk (commercial)
- Win98SE 2001-08-22-06-trunk (commercial)

Comment 17

[Kai Engert (:KaiE:)]

Changing target to 2.1