90997 - Modal dialogs do not stay on top

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P3)

Description

[(Don't use, old account) - Kai Engert]

Several modal PSM dialogs can be hidden by clicking on the parent browser
window. Once they are hidden, the user will be confused and might think the
program is no longer responding to user input.

I'll attach a patch that fixes this for all PSM dialogs that are opened directly
from the browser window.

(However, there are still situations where this doesn't help. The preferences
window is a modeless window. If a modal dialog is opened from the preferences
window, the modal dialog can't be hidden by clicking on the preferences window,
it will stay on top. However, both windows will be hidden by clicking into the
browser window.)

Comment 1

[(Don't use, old account) - Kai Engert]

Attachment: Suggested fix

Comment 2

[(Don't use, old account) - Kai Engert]

The idea for this patch was taken from nsPromptService::DoDialog.
David, can you please review?

Comment 3

[David P. Drinan]

r=ddrinan.

Comment 4

[Stephane Saux]

P3
t->2.1

Comment 5

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 6

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 7

[John Unruh]

Mass assigning QA to ckritzer.

Comment 8

[Javier Delgadillo]

Checked in patch for Kai.

Comment 9

[ckritzer (gone)]

Kai, could you provide some examples of the PSM windows which the user could
open from the browser?  Thanks!  -Kritzer

Comment 10

[(Don't use, old account) - Kai Engert]

For example the dialogs used to set the master password, to query the master
password from the user, to warn about an unknown issuer, mismatched domain or
expired certificate, expired CRL, when download a new CA certificate, to set the
password for the p12 file when exporting a certificate, or when viewing a cert
from the certificate manager.

Comment 11

[Stephane Saux]

Change the target of bugs with state 'RESOLVED' and target 'Future' to target
'2.1' since they were fixed for the 2.1 release.

Comment 12

[bsharma]

Verified on 2001-09-04-Branch build on WinNT

Verified the Master password dialog. Opened this window, and when I click on the
Preference window (parent to this window), the Master password dialog is still
on top.