92387 - Property and value not aligned correctly in Cookie Manager

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Henrik Gemal]

In the Stores Cookies tab in the Cookie Manager there seems to be some problem 
in the alignment of the property and values in the "Information about the 
selected cookie"

Will attach screenshot of the wrong alignment. Seems like the values are align 
to the top and not the middle. It make the UI look weird.

build 20010725

Comment 1

[Henrik Gemal]

Attachment: Screenshot of wrong alignment...

Comment 2

[Henrik Gemal]

Could this be a generel problem with the widget? Adding valign=middle doesn't 
solve anything and I see similary problems in other areas of Mozilla. Fx in Form 
Manager

Comment 3

[Stephen P. Morse]

I too tried the "valign=middle" thinking it would be a simple fix.  But 
when that didn't work, I decided to future it.

Comment 4

[jag (Peter Annema)]

                <row style="border:solid red thin;" autostretch="never">
                  <text style="border:solid green thin;"
value="&props.name.label;"/>
                  <textbox id="ifl_name" readonly="true"/>
                </row>
                <row style="border:solid red thin;">
                  <text style="border:solid green thin;"
value="&props.value.label;"/>
                  <textbox id="ifl_value" readonly="true"/>
                </row>

Comment 5

[jag (Peter Annema)]

Attachment: [screenshot] Shows correct and "incorrect" alignment

Comment 6

[jag (Peter Annema)]

The screenshot shows the two rows I posted in here.

See this part of the spec for details on why valign="middle" looked like it
didn't work:

http://www.mozilla.org/xpfe/xulref/boxref.html#autostretch

Comment 7

[Henrik Gemal]

Attachment: patch to fix alignment

Comment 8

[Henrik Gemal]

I'll provide a patch for Form Manager, which has the same problem...

Comment 9

[Stephen P. Morse]

r=morse for gemal's patch

This report also talks about same problem in form manager.  Attaching patch for 
that.

Gemal, Blake, please review.  Thanks.

Comment 10

[Stephen P. Morse]

Attachment: patch to fix problem in form-manager

Comment 11

[Henrik Gemal]

r=[e-mail]

very minor fixes... Thanx for providing all the patches

Comment 12

[Stephen P. Morse]

Oops, I didn't see gemal's comment saying he would provide patch for form 
manager.  I just did that.  Sorry, I didn't mean to duplicate effort.

Comment 13

[Blake Ross]

autostretch is actually becoming deprecated, soon to be removed.  Cc'ing hewitt.

Comment 14

[Paul Chen]

nav triage team:

If we don't see some r= and sr= lovin' soon, the triage team will push this out
to mozilla0.9.5

Comment 15

[Joe Hewitt (gone)]

autostretch has indeed become deprecated.  Please change all instances of
autostretch="never" in the patch to align="center".

Comment 16

[Stephen P. Morse]

hewitt, brendan, consider patch changed as indicated in hewitt's comment.  
Please review the patch with this modification.

Comment 17

[Brendan Eich [:brendan]]

I defer to hewitt on this one.  Hewitt, how about an sr= stamp in this bug?

/be

Comment 18

[Joe Hewitt (gone)]

sr=hewitt

Comment 19

[Asa Dotzler [:asa]]

please attach the updated patches to the bug and you have approval to check them
in (a=asa on behalf of drivers). thanks.

--Asa

Comment 20

[Stephen P. Morse]

Attachment: updated patches for form manger

Comment 21

[Stephen P. Morse]

Attachment: updated patches for cookie manager

Comment 22

[Stephen P. Morse]

Checked in.

Comment 23

[Tom Everingham]

verified:

WinNT 4 2001-09-20-11-0.9.4
Mac os9 2001-09-20-12-0.9.4
Linux rh6 2001-09-20-17-0.9.4