Closed Bug 92870 Opened 23 years ago Closed 16 years ago

newpower.com - Can see HTML comments in the page.

Categories

(Tech Evangelism Graveyard :: English US, defect, P2)

Product:
Tech Evangelism Graveyard
Component:
English US
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mgalli, Unassigned)

References

(
URL
)

Details

(Whiteboard: [bugscape: 7311][SYNTAX-HTML] [SYNTAX-COMMENTS][DOCTYPE][aok])

Attachments

(2 files)

testcase with the --> added to the link 750.
43.15 KB, text/html
Details
Testcase
246 bytes, text/html
Details 
Not sure if this is layout or parser or.. even not a bug.  Use Gecko latest and
see the above URL. 

Look for (in the layout):
=--------

 END OF LEFT COLUMN -->
Problem:
--------
We can see a piece of the HTML comments. 
Tested with Gecko - Gecko/20010726 in WIn98. 

Additional information:
========================

With View Source code, see the following area:
----------------------------------------------
 <!--END OF MAIN NAV-->

<!-- Left Nav starts here 

			<div class="left">
<TABLE WIDTH="200" BORDER="0" CELLSPACING="0" CELLPADDING="0">
<TR>
<TD COLSPAN="5" valign="middle"><IMG SRC="/images/spacer.gif" WIDTH="200"
HEIGHT="1" ALT="" BORDER="0"></TD>
</TR>

<!-- measuring cells
				<TR>
<TD><IMG SRC="/images/spacer.gif" WIDTH="8" HEIGHT="8" ALT="" BORDER="0"></TD>
<TD><IMG SRC="/images/spacer.gif" WIDTH="24" HEIGHT="1" ALT="" BORDER="0"></TD>
<TD><IMG SRC="/images/spacer.gif" WIDTH="10" HEIGHT="1" ALT="" BORDER="0"></TD>
<TD><IMG SRC="/images/spacer.gif" WIDTH="150" HEIGHT="1" ALT="" BORDER="0"></TD>
<TD><IMG SRC="/images/spacer.gif" WIDTH="8" HEIGHT="1" ALT="" BORDER="0"></TD>
</TR>
</TABLE>
</DIV>
</TD>
END OF LEFT COLUMN -->
<!-- Left Nav starts here -->

===============================================
Note for: 

1] <!-- Left Nav starts here 
2] <!-- measuring cells
3] END OF LEFT COLUMN -->

If you view this with View Source option. You will see that all this code (area
between 1] and 3] ) is highlighted with green color (HTML comments). 
But if you visualize the page, you can see the 3] content. 

Seems like the View Source is dealing okay with this area 1] until 3].

----------------------------------------------------------------
I believe they intended to make all the green area as comments. 1] to 3]. 

Important info:
-----------------
Seems like the item2] is causing the problem. Looking in the source I found that
other areas in the code have lines like the item 2]. But with the proper
characters to end the comment. 

Then I added  "-->" to item 2]. It fixes the page (all the area 1] until 3]
turns to be a comment).

Will add the testcase with the "-->" added to the line 750 (item 2]).
Attached file Testcase — 

    
    

    
  
Page uses:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">

and has comments like:

<!---------------------------------------------------------------------------------------->
<!-- Date	Programmer		Modification 											-->
<!-- --------	-------------	---------------------------------------------------------->

These are parsed per spec in strict mode, with the result that some text ends up
being not commented when the author thinks it is, and some text ends up
commented when the author thinks it is not.

See my comments in bug 79139 for an explanation of how strict comment parsing works.

Over to evangelism
Assignee: harishd → bclary
Status: UNCONFIRMED → NEW
Component: Parser → Evangelism
Ever confirmed: true
QA Contact: bsharma → zach
Summary: Can see HTML comments in the page. → Can see HTML comments in the page.
Whiteboard: [SYNTAX-HTML][SYNTAX-COMMENTS]

    
    

    
  
Since the DOCTYPE is strict we're parsing the comments strictly. The comment
declaration in the above page does not follow SGML spec.

Per SGML spec.

comment declaration =
  <!,
  comment,
  (s*|comment),
  >

comment =
  --,
  SGML Characters,
  --

Refer to my testcase. 

Evangelism please..
Whiteboard: [SYNTAX-HTML][SYNTAX-COMMENTS]

    
    

    
  
FYI: View source is always parsed in quirks mode. :-(

    
    

    
  
these got blown away somehow...
Whiteboard: [SYNTAX-HTML] [SYNTAX-COMMENTS]

    
    

    
  
I'm not sure that this is related to this one... take a look at
http://www.dithered.com . In the top of the blog is displayed this:

    .
    00:00 permalink

Which should not be displayed. In the source this part looks like this:

   <!--dt><b>08/00/2001</b> ---day</dt>
   <dd>
   <p><a name="00_1"></a>.<br />
   <span class="itemstats">00:00
   <a href="/archives/200108.html#00_1">permalink</a></span></p>
   </dd-->

In view source it's highligted as comment correctly. Is this a valid SGML
comment or not? Or is this a Moz bug?

--mondo

    
    

    
  
Pavol,

<! starts the SGML markup

--dt><b>08/00/2001</b> --  is the comment

-day</dt>  is the remaining SGML markup.

Everything after that is parsed as uncommented HTML.

View source is buggy -- it always parses comments in quirks mode.  There is a
bug on this.


    
    

    
  
OK. I've read Boris Zbarsky's comments in bug 79139 so I see that on
dithered.com is incorect SGML comment, page claims to be XHTML 1.0, so strict
mode parsing is in use. I'll write to Chris Nott (chris@dithered.com) [who is
owner of that site] about it. I'll point him to Boris's explation. 

--mondo

    
    

    
  
All Evangelism Bugs are now in the Product Tech Evangelism. See bug 86997 for
details.
Component: Evangelism → US English
Product: Browser → Tech Evangelism
Version: other → unspecified
OS: other → All
Priority: -- → P2
Hardware: PC → All
Summary: Can see HTML comments in the page. → newpower.com - Can see HTML comments in the page.
Whiteboard: [SYNTAX-HTML] [SYNTAX-COMMENTS] → [SYNTAX-HTML] [SYNTAX-COMMENTS][DOCTYPE]

    
    

    
  
reassigning to me, .. since the original case bugscape is my one.

Assignee: bclary → mgalli

    
  
Summary: newpower.com - Can see HTML comments in the page. → WRMB: newpower.com - Can see HTML comments in the page.
Whiteboard: [SYNTAX-HTML] [SYNTAX-COMMENTS][DOCTYPE] → [bugscape: 7311][SYNTAX-HTML] [SYNTAX-COMMENTS][DOCTYPE]
Summary: WRMB: newpower.com - Can see HTML comments in the page. → newpower.com - Can see HTML comments in the page.
Whiteboard: [bugscape: 7311][SYNTAX-HTML] [SYNTAX-COMMENTS][DOCTYPE] → [bugscape: 7311][SYNTAX-HTML] [SYNTAX-COMMENTS][DOCTYPE][aok]

    
    

    
  
removing myself from the cc list

    
    

    
  
tech evang june 2003 reorg
Assignee: mgalli → english-us
QA Contact: zach → english-us

    
    

    
  
Closing since the bug is no bug and the site is gone anyway.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
Product: Tech Evangelism → Tech Evangelism Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: