Closed Bug 93170 Opened 23 years ago Closed 22 years ago

OSX: animated gifs have lines through center with plugin on page

Categories

(Core :: Graphics: ImageLib, defect, P2)

PowerPC
macOS
defect

Tracking

()

VERIFIED DUPLICATE of bug 137295
mozilla1.0

People

(Reporter: chrispetersen, Assigned: sdagley)

References

()

Details

(Keywords: top100, topembed+, Whiteboard: [adt1 RTM])

Attachments

(10 files)

Build: 2001080105
Platform: Mac OS X
Expected results: No paint problem inside or around table
What I got: Banners ads at the top and bottom of table are not completely painted.

Steps to reproduce:

1) Go to http://www.macshowlive.com/archive.html
2) Reduce the size of the window.
3) Notice portions of top /bottom ads are not painted properly. Small gif (upper
right of table) appears outside of table.
4) I can't reproduce this painting problem under Mac OS 9.1.
Attached image screen shot of problem
We need a reduced test case.
Keywords: qawanted
Summary: Paint problem when table is resized → Paint problem when table is resized
I spent some researching this issue noticed the "stream" buttons are actually qt
movies that have their controllers hidden.  If you replace these four QT movies
with images (download.jpg), the painting issue doesn't reproduce when resizing
the window.
Peter, 

Can you take a look at this ?
This is likely my bug if it only happens on OS X, but I think it could be a dup. 

Petersen, can you attach a minimal testcase? Thanks!
Assignee: karnaze → peterlubczynski
Component: Layout → Plug-ins
Keywords: qawanted
Summary: Paint problem when table is resized → OSX: Paint problem when table with QT is resized
Changed summary since problem isn't table related
Summary: OSX: Paint problem when table with QT is resized → OSX: Paint problem when page containing GIF and QT movie is resized
Further reduced test case. Align = center removed. Problem still occurs  when
resizing window.
Problem occurs with Flash object and animated gifs as well. See warner test
case. When window is resized painting issue appears on gifs
Summary: OSX: Paint problem when page containing GIF and QT movie is resized → If a page contains QT/Flash object and animated gif, a paint problem will occur when the window is resized
images don't paint--->imagelib/pavlov
Assignee: peterlubczynski → pavlov
Component: Plug-ins → ImageLib
QA Contact: petersen → tpreston
Is anyone actively looking at this bug ? This problem is ugly and occurs on
various pages including warner's bros site.
nominate nsbranch and cc: nisheeth.
Keywords: nsbranch
This works fine on windows.  I don't have a mac to test it on..  I will get 
together with someone with OSX to try and reproduce this and figure out what is 
going on.

If I had to guess, I expect there is something bad going on with timers and 
events on OSX that is causing the animation timers not to get fired.
Priority: -- → P4
Target Milestone: --- → mozilla0.9.5
cc'ing bnesse. brian, doesn't this sound like the same problem as weather.com 
that i've been hounding you about for months? ;)
That would be bug 76085. If indeed this is a dup it is not OSX only, simply Mac
only.
I think bug 76085 is a little different. Attachment #47273 [details] shows a very simple
testcase with a white band through the middle of the image when the image is not
animating or the window is being resized.

Also, a single click anywhere in the plugin causes the white band to be painted.
My guess is that the plugin is painting outside it's area because the clip isn't
set correctly, possibly in ProcessEvent. Reassiging back to myself....
Assignee: pavlov → peterlubczynski
Keywords: nsbranchnsbranch-
Whiteboard: [OSX-]
bug http://bugzilla.mozilla.org/show_bug.cgi?id=76085 (which folks suspect this
is a duplicate of) mentions that layout folks' help is needed.

Because some internal sites are affected, I wonder if this will come back to
haunt us. I will inquire.
Similar problem occurs on static GIF 89A so it's not just animated gifs

http://www.tnt.tv/index.html

Resizing window will should problem in the "TNT Spotlight" section.
Attached file TNT sample
Take a look at the TNT sample test. Contains a static GIF89a image and flash
embed element. If you resize the page so that only the gif is visible, it
renders properly. The both the flash object and the gif are both visible , the
gif renders incorrectly.
If you scale the image via HTML by a pixel (larger or smaller), the problem no
longer occurs either. I have added another test case to show this.
Does today's build (branch or trunk) show this problem?
Yes, the Mac OS X 2001-09-28-04-0.9.4 build is showing the problem still.
dagley - there weren't any comments in this bug, on why it received an OSX- ...
seeking a little guidance here ...
Guess what ? I noticed this problem only happens when the monitor bit depth is
millions. I couldn't reproduce this problem on my iBook which was set to
thousands. Setting the LCD to millions would immediately cause problem. Tried
this out on my G4/450 running 10.1 and verified that thousands of colors mode
solves problem. 
That's good to hear.  What is the default setting on Macs when purchased?
Chris - this may be a good item to add to the release notes tracking bug for
folks to try.  

I thought I had seen a similar problem filed before.  I will have to look to see
if I can find it.
> What is the default setting on Macs when purchased?
Millions...
I tried some extra "fixing up" of the plugin window plus saving off the GrafPort
with no luck.

Upon a closer look with attachment 47322 [details] which has a yellow background, I know
the plugin is NOT painting on top of the animated gif. Maybe the problem is in
image code instead of plugin code.

I'll keep looking but it's difficult without being able to set breakpoints. The
lastest CW7 on macdev does not stop on my breakpoints.
Blocks: 102998
Target Milestone: mozilla0.9.5 → mozilla0.9.6
...back over to Pavlov because I think it could be a problem in image code....if
not and it's something with plugins, feel free to send back to me...
Assignee: peterlubczynski → pavlov
-> future.  I'm not going to have time to look at this anytime soon.  I don't
have a mac to test this on.
Target Milestone: mozilla0.9.6 → Future
I really don't like the fact that this issue has been futured. OS X users will
see this problem since it happens on a variety of pages listed. I'm sure if this
was happening on our own netscape page, we would spend time to resolve it.
However, it's happening on several warner bros sites since that combine flash
and gifs on the same page.
ESPN main page has the same problem as described:
http://msn.espn.go.com/main.html
On the EPSN site, a gap is drawn over the MSN header logo and the video
highlight (animated gif) add which is positioned to the right of the ESPN
navigation bar.
pav won't be of much help here. giving to saari who might actually care.
Assignee: pavlov → saari
Target Milestone: Future → ---
Removing - from nsbranch since it's occuring on additional sites. See my
previous comments listed.
Keywords: nsbranch-nsbranch
Disney's go site has this problem on the top banner ad :


http://disney.go.com/park/homepage/today/flash/index.html

I also see this problem at www.planetofmusic.com (I don't think users will 
easily figure out to change their settings to thousands and therefore will 
continuously run into this bug)
Was this renominated in hopes that it will make 094 for OSX? 
My goal was to have this further discussed by PDT. This painting problem is very
noticeable when monitor color depth is set to millions under OS X (which is the
default). Espn , Disney, and Warner Bros sites are listed in our top 100 so I
concerned that the majority of OS X users will see these painting issues.
k ... Adding PDT to Status Whiteboard for further discussion.
Whiteboard: [OSX-] → [OSX-] [PDT]
I also can't reproduce on 9.1. I'll need an OS X box to get anywhere with this.
Can't think of a reason why we'd have animated GIF issues on X and not on 9.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.6
Yes, you won't see this problem under 9.1. Also, the problem happens mostly with
animated gifs but does occasionly occur on static GIF. The TNT site shows a
painting issue with the four gifs in the "TNT" spotlight section.
http://www.tnt.tv/index.html

can you look into this with saari.

no pacth. PDT-
Summary: If a page contains QT/Flash object and animated gif, a paint problem will occur when the window is resized → If a page contains QT/Flash object and animated gif, a paint problem will occur when the win
Whiteboard: [OSX-] [PDT] → [OSX-] [PDT-]
petersen - I tried a few test cases here:
http://www.macshowlive.com/archive.html
http://www.tnt.tv/index.html
http://looneytunes.warnerbros.com/web/looney_library/library_story.jsp
http://shopping.warnerbros.com/
and then resized my window and I don't see paint problems.

I am on an iMac, OS 10.0.4, millions of colors, 1024x768



tpreston pointed out to me that sites change their ads so I may not see the
problem all the time.

I tried petersen's reduced test case at
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=47273.  When I resize
the window, I do see that part of the current ad blanks out slightly until the
next ad draws/appears.  If we normally see this problem on banner ads, it
appears that the problem gets corrected when the next ad gets served.  Is this
your observation?
Lisa,

I have noticed the animated gif banners can correct themselves when the next
image in the sequence loads. But isn't always the situation. Sometimes the
second and third image in the sequence will have the gap in them. If the problem
is resolved by loading another image, you will see the problem again if the
problem is window resized again (while the image is displayed) See "wb" attachment.

Another related issue is that some animated gifs appear to partially tile. This
was noticeable at one of the warner sites. See "wb2" attachment. The problem
(bug gif in center of page)isn't fixed when the next image in the that sequence
is loaded.


Static gifs can be displayed with portions missing. See "tnt" attachment. There
isn't a way this can be corrected except to change colors to thousands.
Tested on Mac OS X 10.1, iBook, Millions, 1024 x 768
Blocks: 107065
Keywords: nsbranch
Target Milestone: mozilla0.9.6 → mozilla0.9.7
*** Bug 108866 has been marked as a duplicate of this bug. ***
Whiteboard: [OSX-] [PDT-] → [OSX-] PDT
Removing PDT grafitti from Status Whiteboard.
Whiteboard: [OSX-] PDT → [OSX-]
I made a Web page demonstrating this bug in a very simple context:
http://segal.org/blankbar/index.html
It was used for bug 108866, which has been marked as a duplicate of this bug.  
The page has a simple example and full source code in a link.
taking bug so saari's head doesn't expolde
targeting 098 since it won't make 097
Assignee: saari → sdagley
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Added Applet to summary.
Summary: If a page contains QT/Flash object and animated gif, a paint problem will occur when the win → If a page contains QT/Flash/Applet object and animated gif, a paint problem will occur when the win
Here is one of Apple's site where the problem occurs.
(http://www.apple.com/quicktimelive/why.html)

The page contains a QT movies and noticeable gap appears in the Quicktime Live
image and Top Reasons to Attend image.

Any progress on getting this resolved ? 
Unfortunately not.  The hope was that pav's timer rewrite would change this 
behavior since it affects how animated images are drawn but that appears not to 
be the case.

And just noting some additional info.  The segal.org test page exhibits the 
problem event when you don't have the Carbon MRJ plugin installed so it happens 
even without the plugin actually being instantiated
Chris,

On a related note, any problems accessing <http://www.apple.com/quicktimelive/
why.html> from the Classic Mac OS Mozilla build?  Running the Carbon Mozilla 
build under Mac OS 9.2.2 results in a crash accessing that page.

Let me download that version and reboot under OS 9.2.1.
I didn't experience a crash when loading this page under OS 9.2.1. Tested with
the Jan 3rd build (2002-01-03-04). I have QT 5.0.2 installed but after loading
the page I got a message that said I needed to update QT for a (QT Channels)
component. I clicked OK and it got installed. 
Whiteboard: [OSX-]
--> 0.9.9
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Here is another site that shows the problem:

http://www.shockwave.com/sw/games/

Gaps appear in the various headings like action -adventure, shooters, 3d games,
multiplayer, puzzle games, etc...
Repharsing summary from: [If a page contains QT/Flash/Applet object and animated
gif, a paint problem will occur when the win]
Summary: If a page contains QT/Flash/Applet object and animated gif, a paint problem will occur when the win → OSX: animated gifs have lines through center with plugin on page
Adding nsbeta1
Keywords: nsbeta1
Blocks: 119597
Priority: P4 → P2
plusing - ADT/Embedding triage team.
Keywords: nsbeta1nsbeta1+
-> mozilla1.0
Target Milestone: mozilla0.9.9 → mozilla1.0
Nominating for topembed
Keywords: topembed
Hunch: the CopyBits that copies from one image frame to the next
(nsImageMac::CopyToImage or somesuch) is being clipped by the clipping of the
(implicit) current port, which has been set by plugins. Maybe.
Keywords: topembedtopembed+

*** This bug has been marked as a duplicate of 137295 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
Verified Duplicate
Status: RESOLVED → VERIFIED
No longer blocks: 119597
Blocks: 143047
Whiteboard: [adt1 RTM]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: