Closed Bug 93426 Opened 23 years ago Closed 20 years ago

Followups / replies are placed in thread in wrong order

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ewv, Assigned: neil)

References

(Blocks 1 open bug)

Details

(Keywords: fixed-aviary1.0)

Attachments

(5 files, 2 obsolete files)

Screenshot showing bad threading
26.76 KB, image/png
Details
Part 1
2.61 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
Unoptimize again ;-)
8.05 KB, patch
Bienvenu
: review+
mscott
: superreview+
Details | Diff | Splinter Review
Screenshot showing still bug
7.12 KB, image/png
Details
Fix
3.54 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
chofmann
: approval1.7.5+
Details | Diff | Splinter Review 
I've noticed this problem for a long time, but have just now done a little
research into to make sure it wasn't a posting problem.

What I see is a news tree like this

#1L#2
L#3
L#4
 L#5

When in fact message #5 is in response to message #2, not message #4. 

From view message source, here are the MessageID and reference headers:

#1
Message-ID: <3B6A6246.2020308@cs.com>

#2
Message-ID: <3B6A7AF1.8090305@cs.com>
References: <3B6A6246.2020308@cs.com>

#4
Message-ID: <3B6A7FF9.3040403@netscape.net>
References: <3B6A6246.2020308@cs.com>

#5
Message-ID: <3B6BD1BE.9040302@optonline.net>
References: <3B6A6246.2020308@cs.com> <3B6A7AF1.8090305@cs.com>

So it's getting the depth correct, but the attribution completely wrong.

My settings are "Sort by Thread", Threaded mode, unread messages only.

The specific thread these examples are from n.p.m.general entitled "Milestone
0.9.3 is MASSIVELY broken..." by Peter Lairo
QA Contact: esther → stephend
Is anyone else seeing this with the settings I describe? I filed this bug five
months ago and there has been no acknowledgement that this bug even exists. I
still see it all the time, even with 0.9.7
You're not the only one.  I've seen this for a long time too, up to and
including Linux build 2001122808.  It seems to be sorting messages within
threads by message number, rather than grouping sub-threads together.
And then setting the depth based on how many references there are?
I see this, but only straight after I make a reply like #2 above.  If I go out
and come back into the newsgroup it is threaded correctly.
I've seen this a couple of times on Win2k (but only until I leave the group and
come back, like clef). Changing OS and Platform to All.
OS: Linux → All
Hardware: PC → All
*** Bug 136364 has been marked as a duplicate of this bug. ***
Summary: Threading in news is incorrect → New news followups/replies are placed last in thread after Get New Messages
http://bugzilla.mozilla.org/attachment.cgi?id=78327

The above PNG is attached to the bug Jonas marked a duplicate, and is a good
visual as to what the problem is. Note that the highlighted message from Boris
is in response to Lydia's message.

This bug is still here for me, Moz 1.0 release (2002053012) WinXP.

It seems that it isn't redrawing the entire message list when you "Get New
Messages". When I collapse and re-expand the misbehaving thread, or change
newsgroups and return later, all is well. Hopefully it's an easy fix... :)
That bug might be a duplicate, but what my original report was is that even if
it looks visually correct, what mozilla says are the children of a message are
not. It puts the wrong childrend with the wrong parents.
*** Bug 143971 has been marked as a duplicate of this bug. ***
*** Bug 162226 has been marked as a duplicate of this bug. ***
Nominating nsbeta1.
Keywords: nsbeta1
*** Bug 125987 has been marked as a duplicate of this bug. ***
From bug 125987

This also applies to Mail, not only to news messages. This is probably known,
but I could't find a reference for this in the comments of this bug.
*** Bug 166551 has been marked as a duplicate of this bug. ***
I'm attaching a screenshot showing this effect. Here you will see one thread
started by a troll. There are five replies. The troll responds to 3 of them,
but the responses show up as all being to the last reply. 

Then, you can clearly see that someone starts a subthread about "Worst troll,"
etc. But that subthread is broken in two pieces by this bug.

I've gone and done some spot checks, and in every case, the references look
fine.

If you look at the dates, you can see that what is happening is things are just
being ordered by date, or at best date and reply level within the thread.
Changing title. Title was "New news followups/replies are placed last in thread
after Get New Messages" but this bug is much more widespread than this limited
description would suggest.
Summary: New news followups/replies are placed last in thread after Get New Messages → ollowups/replies are placed in thread in wrong order
Summary: ollowups/replies are placed in thread in wrong order → Followups / replies are placed in thread in wrong order
*** Bug 171264 has been marked as a duplicate of this bug. ***
Blocks: 176238
Still seen on 2002112908/Mac OS X.
Nominating for 1.3a. Actually would like this nominated for 1.3final, but can't
find a way to do this.
Flags: blocking1.3a?
Flags: blocking1.3a? → blocking1.3a-
Mail triage team: nsbeta1+/adt3
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt3]
Using 1.4b on WinXP, this appears to be fixed. :-\ Maybe I'm misunderstanding
the bug, but could someone try to confirm.
tested 2003051408
still broken ie not threading news replies correctly unless you switch to
another folder and back again.

Let me illustrate on our sgi.test newsgroup...

I post three messages, so that it looks like this :

post 1
  post 1-1
  post 1-2

then I select post 1-1 and reply to it with the subject post 1-1-1

I do not change newsgroups or anything, but press the 'Get new messages'
button.

I would expect it to appear :

post 1
  post 1-1
    post 1-1-1
  post 1-2

but, instead, I get :

post 1
  post 1-1
  post 1-2
    post 1-1-1

If I change to another newsgroup or mail folder, and back again, it appears
correctly.

Max.


*** Bug 210031 has been marked as a duplicate of this bug. ***
Wow. 27 months after being reported, and 10 months after a + from triage and
still here. Does the + have to be cleared after something isn't fixed for that
release, or does the + live on until it is fixed?
This bug is #1 on my list, and has been for a long time. I'm not a coder,
however is there *anything*  that I (and other non-coders) can do to help fix
this? (I've already voted for it)
I also vote for this bug. It is quite trouble when I always use
Thunderbird/Mozilla as my usenet client. :(
Blocks: 236849
*** Bug 237863 has been marked as a duplicate of this bug. ***
*** Bug 242449 has been marked as a duplicate of this bug. ***
Attached patch Part 1 — — Splinter Review 
OK, so I'm taking this in small stages. First, I'd like to rename
GetLevelInUnreadView to FindLevelInThread because it also works in threaded
view, but it appears to be slightly more efficient because it only searches the
parents in the current thread.
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #147736 - Flags: superreview?(bienvenu)
Attachment #147736 - Flags: review?(bienvenu)
Attachment #147736 - Flags: superreview?(bienvenu)
Attachment #147736 - Flags: superreview+
Attachment #147736 - Flags: review?(bienvenu)
Attachment #147736 - Flags: review+
Attached patch Part 2 - the real work (obsolete) — — Splinter Review 
I've reorganized the code a bit... FindLevelInThread is now FindParentInThread
because we can find the level from the parent. This means that we can now
insert the new message under the correct parent :-)
This version doesn't attempt to locate the parent if the thread is collapsed.
Attachment #148016 - Attachment is obsolete: true
Attachment #148040 - Flags: review?(bienvenu)
*** Bug 244897 has been marked as a duplicate of this bug. ***
Unfortunately the optimization depended on bug 231846 :-[
Attachment #148040 - Attachment is obsolete: true
Attachment #155202 - Flags: review?(bienvenu)
Comment on attachment 155202 [details] [diff] [review]
Unoptimize again ;-)

looks OK - the proof is in the pudding, so I'll have to run with this for a
bit...you've been running with it no problem for a long time, right?
Attachment #155202 - Flags: review?(bienvenu) → review+
*** Bug 245108 has been marked as a duplicate of this bug. ***
*** Bug 251584 has been marked as a duplicate of this bug. ***
I've applied this patch, and will run with it, as soon as my tree is in running
order again (the account manager port patch has made rss servers unhappy...)
This will be fixed for Thunderbird, too, right?
*** Bug 234801 has been marked as a duplicate of this bug. ***
Comment on attachment 155202 [details] [diff] [review]
Unoptimize again ;-)

The patch bitrotted slightly since bienvenu renamed one of the variables, but
nothing a :%s/msgHdr/newHdr/gc can't fix.
Attachment #155202 - Flags: superreview?(mscott)
*** Bug 200163 has been marked as a duplicate of this bug. ***
Attachment #155202 - Flags: superreview?(mscott) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Is this bug fix eligible for the 1.7 branch?
Can this fix be checked into aviary branch as well?
Comment on attachment 155202 [details] [diff] [review]
Unoptimize again ;-)

Adding request for aviary and 1.7.x approvals, just so this doesn't get lost.
Attachment #155202 - Flags: approval1.7.x?
Attachment #155202 - Flags: approval-aviary?
*** Bug 247247 has been marked as a duplicate of this bug. ***
Flags: blocking-aviary1.0?
I hoped after checking in the patch I don't see this bug anymore. But either
this is about the same problem I see or the patch doesn't work.

This screenshot shows the result of opening a thread in de.test and replying to
two different messages in the thread. Then get new messages. Mozilla used:
20040917
Upper half is right after receiving the new messages, lower half is after
closing and reopening the thread.
Attached patch Fix — — Splinter Review 

    
    

    
  
Comment on attachment 159355 [details] [diff] [review]
Fix

Don't ask me what happened to FindParentInThread, but I still have the .msf
with a thread that I created to test my original patch...

        Attachment #159355 -
        Flags: superreview?(bienvenu)

        Attachment #159355 -
        Flags: review?(bienvenu)

    
    

    
  
Comment on attachment 159355 [details] [diff] [review]
Fix

I'll have to fix this to take a msg hdr again when I add threading to
cross-folder views, but for now this is OK.

        Attachment #159355 -
        Flags: superreview?(bienvenu)

        Attachment #159355 -
        Flags: superreview+

        Attachment #159355 -
        Flags: review?(bienvenu)

        Attachment #159355 -
        Flags: review+

    
    

    
  
ch.ey, hopefully this is really fixed now :-)

    
    

    
  
(In reply to comment #51)
> ch.ey, hopefully this is really fixed now :-)

Yeah, I couldn't produce wrong threading anymore with the latest nightly. Thanks
for patching this annoying bug!

    
  
Flags: blocking1.3a-

    
    

    
  
Now that there's a new patch, can someone add a request for approval in the
1.7.x and aviary branches to the new patch?

    
    

    
  
*** Bug 261504 has been marked as a duplicate of this bug. ***

    
  

        Attachment #159355 -
        Flags: approval1.7.x?

    
    

    
  
Comment on attachment 159355 [details] [diff] [review]
Fix

a=chofmann for the branches

        Attachment #159355 -
        Flags: approval1.7.x? → approval1.7.x+

    
    

    
  
Woohoo!  I'm so glad this is fixed.

/be

    
  

        Attachment #155202 -
        Flags: approval1.7.x?

        Attachment #155202 -
        Flags: approval-aviary?

    
    

    
  
I've ported these fixes best I can to aviary branch.
Keywords: nsbeta1+ → fixed-aviary1.0
Whiteboard: [adt3]

    
  
Flags: blocking-aviary1.0?

    
    

    
  
Thank you, so much for fixing this. It is much appreciated. Neil, if you ever
need  traditional Greek band, just say the word; and I'm there for ya. :-)

    
    

    
  
Comment on attachment 148040 [details] [diff] [review]
Part 2 optimized for collapsed threads

cancel obsolete review request

        Attachment #148040 -
        Flags: review?(bienvenu)
Product: Browser → Seamonkey

    
    

    
  
Bug fix not successfull in my case: see Bug 324017
No longer blocks: 236849

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: