964217 - Search item is broken in customization mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[u428464]

I noticed a few bugs with the search bar in customization mode.

1. The item has no text in the palette
2. The box is cut on the right
3. The item can't be placed back to the right of the location bar because the other widgets are placed immediately there after the item is dropped.

Comment 1

[:Gijs (he/him)]

At least the cut-off-ness is a regression...

Comment 2

[:Gijs (he/him)]

I tried to bisect this using mozregression and got nowhere. :-\

Comment 3

[:Gijs (he/him)]

This was regressed by the flex code I added in bug 922834.

Comment 4

[:Gijs (he/him)]

Attachment: search item is broken in Australis' customize code,

So this fixes the styling of the search bar and the bookmarks bar. There's still a separate issue that only occurs if moving the bookmarks toolbar items from the palette to the menu panel, but stops as soon as they've been in the toolbar. Don't think that needs to hold up this bug, though.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8366667 [details] [diff] [review]
search item is broken in Australis' customize code,

Review of attachment 8366667 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following comment addressed:

::: browser/themes/linux/browser.css
@@ +118,5 @@
>  }
>  
> +#wrapper-personal-bookmarks:not([place="toolbar"]) > #personal-bookmarks {
> +  -moz-box-pack: center;
> +}

since you're adding the same block to all platforms' CSS, I'd like you to put this in customizeMode.inc.css

Comment 6

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/849724d4081e

Leaving open for point 3 from comment 0.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/849724d4081e

Comment 9

[:Gijs (he/him)]

3. is because of the search splitter state, which is getting confused. :-\

Comment 10

[:Gijs (he/him)]

Attachment: fix search item insertion in Australis customization mode,

So basically, what happens is, customize mode removes the splitter, but then the overflowable toolbar gets disabled, which calls _moveItemsBackToOrigin, which then promptly calls UpdateUrlbarSearchSplitterState, which puts it back again. Let's just teach UpdateUrlbarSearchSplitterState (who picked that function name?) to Not Do That (tm).

Comment 11

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/db60ba91be47

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db60ba91be47

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0


All scenarios mentioned in description are now fixed on latest Firefox Aurora (Build ID: 20140317004002).