Closed Bug 97347 Opened 23 years ago Closed 22 years ago

Buttons do not obey width/height attrs

Categories

(Core :: Layout: Form Controls, defect, P2)

x86
Windows NT
defect

Tracking

()

RESOLVED WONTFIX
Future

People

(Reporter: serhunt, Assigned: rods)

References

()

Details

(Keywords: compat, testcase)

Attachments

(4 files)

I am not sure about the component, could be Form Submission.

This site is a Russian electronic book/music store.
1. Go to this site
2. Locate search engine interace on the lefthand side, it says NETSCAPE USERS
CLICK HERE and Russian Keyboard there. There is a nice feature for those who
don't have their machine russified: click on Russian Keyboard pops up a window
which resembles a keyboard and can be used to type chars in the search box.
3. Click on Russian Keyboard

Actual result: what we see with Mozilla (attachment follows)
Expected: what we see with 4x (attachment follows)

The direct link to 'keyboard' html code is http://www.st-p.com/Nkeyboard.asp
looks like we ignore the illegal width and height attributes on <input
type="submit".  What we should consider doing is attribute mapping in quirks
mode only.  Using style="width: whatever; height: whatever" on that page works
beautifully, by the way.

Over to HTML form controls.
Assignee: karnaze → rods
Component: Layout → HTML Form Controls
QA Contact: petersen → madhur
Priority: -- → P1
Summary: Buttons are of wrong size → [Fix]Buttons do not obey width/height attrs
Whiteboard: Fix in hand
Target Milestone: --- → mozilla0.9.5
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Rod, shouldn't this use style to resolve width and height? What about the % case?
Summary: [Fix]Buttons do not obey width/height attrs → [FIX]Buttons do not obey width/height attrs
Rod, does Nav only support PX width and height, or does it support others, like
percentage too? Also, we usually do this kind of thing in MapAttributesIntoRule
in the content element - I think that would be better.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
moving to 0.9.6
Target Milestone: mozilla0.9.6 → mozilla0.9.9
Keywords: compat, testcase
Target Milestone: mozilla0.9.9 → mozilla1.0
Summary: [FIX]Buttons do not obey width/height attrs → Buttons do not obey width/height attrs
Keywords: mozilla1.0
Whiteboard: Fix in hand
Target Milestone: mozilla1.0 → mozilla1.1
Priority: P1 → P2
Target Milestone: mozilla1.1 → Future
QA Contact: madhur → tpreston
Unless there is a _really_ good reason to fix this, I would suggest wontfix....
 If there is one and only one site using it, we should not make a quirk for it.
Re: Comment 4, The button tag does still does not handle css height and width
correctly anyway. bug 128115
I saw it.  I have it fixed in my tree, in fact.
I just eliminated quirks reflow for buttons.  With my changes the keyboard looks
a lot more reasonable and I am somewhat tempted to wontfix this bug... Do people
feel that we should really support this in quirks?
NO KILL quirks!
Ok.  We don't support this.  We show the keyboard OK.  IE5 does not support it
either.  So the only thing supporting it is NS4....
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → WONTFIX
...and IE6 :(
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: