1591900 - Expose third-party state in WebRequest and proxy onRequest details

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task)

Description

[Andrea Marchesini [:baku]]

This is important to have for secure-proxy.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1591900 - Expose third-party state in WebRequest and proxy onRequest details, r?smaug r=mixedpuppy

Comment 2

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e99290edd750
Expose third-party state in WebRequest and proxy onRequest details, r=mixedpuppy,smaug

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b142af8ea72b
Backed out changeset e99290edd750 for causing lint failures in file_third_party.html CLOSED TREE

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset e99290edd750 for causing lint failures in file_third_party.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/b142af8ea72be3164e1dd6bd638b4fa17852467b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=b142af8ea72be3164e1dd6bd638b4fa17852467b&fromchange=e99290edd7502a8ec23357c8a68e1e66d3c7828d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273628446&repo=autoland&lineNumber=331

[task 2019-10-30T07:09:30.262Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-10-30T07:25:59.566Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/components/extensions/test/mochitest/file_third_party.html:11:1 | Use the global form of 'use strict'. (strict)
[taskcluster 2019-10-30 07:25:59.947Z] === Task Finished ===

Comment 6

[Alexandru Michis [:malexandru]]

Closed by misclicking, reopening

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed867296b6d4
Expose third-party state in WebRequest and proxy onRequest details, r=mixedpuppy,smaug

Comment 8

[Alexandru Michis [:malexandru]]

Backed out changeset ed867296b6d4 for causing mochitest fission failures in test_ext_activityLog.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/19669f57bc0182cbf694c3494b73009e360462d1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=ed867296b6d4affe4996fa77b277ed52b210b1dc&fromchange=e99290edd7502a8ec23357c8a68e1e66d3c7828d&selectedJob=273633355

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273633355&repo=autoland&lineNumber=7536

[task 2019-10-30T08:26:43.772Z] 08:26:43 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_activityLog.html | name matches - Expected: webRequest.onBeforeRequest, Actual: webRequest.onBeforeRequest
[task 2019-10-30T08:26:43.773Z] 08:26:43 INFO - Buffered messages finished
[task 2019-10-30T08:26:43.775Z] 08:26:43 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_activityLog.html | message matches - Expected: {"args":[{"url":"http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_sample.html","method":"GET","type":"main_frame","frameId":0,"parentFrameId":-1,"ip":null,"frameAncestors":[],"incognito":false}],"result":{"cancel":false}}, Actual: {"args":[{"url":"http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_sample.html","method":"GET","type":"main_frame","frameId":0,"parentFrameId":-1,"thirdParty":false,"ip":null,"frameAncestors":[],"incognito":false}],"result":{"cancel":false}}
[task 2019-10-30T08:26:43.776Z] 08:26:43 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-10-30T08:26:43.777Z] 08:26:43 INFO - testHandler@SimpleTest/ExtensionTestUtils.js:59:18
[task 2019-10-30T08:26:43.778Z] 08:26:43 INFO - testResult@SimpleTest/ExtensionTestUtils.js:73:18

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26616eb7c174
Expose third-party state in WebRequest and proxy onRequest details, r=mixedpuppy,smaug

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/26616eb7c174

Comment 11

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26616eb7c174

Comment 13

[Richard Bloor]

'thirdParty` is now documented on:

• proxy.RequestDetails.
• the details property of callback for all of the events in webRequest.

A pull request is pending for updates to the compatibility table data: 5582

Please let me know if any changes are needed.

Comment 14

[Richard Bloor]

Did this update include Firefox for Android?

Comment 15

[Andrei Ciure[:aciure]]

It's not clear to me why I'm ni on this bug? I only merged this bug to central and have no other insight regarding the work done on this bug.