Picture-in-Picture - Pass keyboard commands from PiP window to origin window
Categories
(Toolkit :: Video/Audio Controls, enhancement)
Tracking
()
People
(Reporter: adamopenweb, Assigned: gl, NeedInfo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
We received feedback that users would like to be able to use keyboard controls in the PIP window to control the video, for example scrubbing back and forth.
We know that implementing a full scrubber UI is going to take a lot of effort to build.
If this is relatively straight-forward to do, it would provide a decent workaround and quickly.
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Comment 2•1 month ago
|
||
ni?ing MattN for the question I asked in https://phabricator.services.mozilla.com/D58273#1805826.
| Assignee | ||
Comment 3•1 month ago
|
||
Needinfoing @Masayuki and @m_kato on the question asked in https://phabricator.services.mozilla.com/D58273#1812291
Updated•1 month ago
|
| Assignee | ||
Comment 4•14 days ago
|
||
This implements keystroke handling behind a pref "media.videocontrols.picture-in-picture.keyboard-controls.enabled".
This patch handles all the keystrokes for video controls, which include play, pause,
volume decrease and increase, mute, unmute, seek forward and backward for 15 seconds
or by 10% of the max video duration, seek to beginning and seek to end.
This reuses the key handler logic from https://searchfox.org/mozilla-central/rev/cfd1cc461f1efe0d66c2fdc17c024a203d5a2fd8/toolkit/content/widgets/videocontrols.js#1687-1810.
Updated•13 days ago
|
| Assignee | ||
Updated•13 days ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82d1507999fd Implement keystroke handling for PiP window for video controls. r=mconley
Comment 6•10 days ago
|
||
| bugherder | ||
Comment 7•9 days ago
|
||
Could we get a release note addition please? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F
| Assignee | ||
Comment 8•1 day ago
|
||
Adam, can I have you craft the release note? I would be happy to review.
Description
•