Closed Bug 1610485 Opened 1 month ago Closed 1 month ago

Crash in [@ InvalidArrayIndex_CRASH | mozilla::AntiTrackingCommon::RedirectHeuristic]

Categories

(Core :: Privacy: Anti-Tracking, defect, critical)

Desktop
All
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 blocking fixed

People

(Reporter: pascalc, Assigned: baku)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 obsolete file)

This bug is for crash report bp-23e359ea-035c-456b-8e4f-dc3ae0200121.

Top 10 frames of crashing thread:

0 libxul.so InvalidArrayIndex_CRASH xpcom/ds/nsTArray.cpp:27
1 libxul.so mozilla::AntiTrackingCommon::RedirectHeuristic toolkit/components/antitracking/AntiTrackingCommon.cpp:2379
2 libxul.so mozilla::net::nsHttpHandler::AsyncOnChannelRedirect netwerk/protocol/http/nsHttpHandler.cpp:837
3 libxul.so mozilla::net::InterceptedHttpChannel::ResetInterception netwerk/protocol/http/InterceptedHttpChannel.cpp:656
4 libxul.so mozilla::dom::ServiceWorkerPrivate::SendFetchEvent dom/serviceworkers/ServiceWorkerPrivate.cpp:1568
5 libxul.so mozilla::dom:: dom/serviceworkers/ServiceWorkerManager.cpp:2000
6 libxul.so nsPermissionManager::WhenPermissionsAvailable extensions/permissions/nsPermissionManager.cpp:3300
7 libxul.so mozilla::detail::RunnableFunction<mozilla::dom::ServiceWorkerManager::DispatchFetchEvent xpcom/threads/nsThreadUtils.h:562
8 libxul.so mozilla::net::HttpBaseChannel::EnsureUploadStreamIsCloneable netwerk/protocol/http/HttpBaseChannel.cpp:879
9 libxul.so mozilla::dom::ServiceWorkerManager::DispatchFetchEvent dom/serviceworkers/ServiceWorkerManager.cpp:2195

This is a new crash spiking in build 20200121093246
https://hg.mozilla.org/mozilla-central/changeset/9fd9eeb8160fe73aa68300b9ddaefef3fbddeec2

Changelog with the previous build:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=59873ee30955167ac1c6cc1eaafcbeda834ef74d&tochange=9fd9eeb8160fe73aa68300b9ddaefef3fbddeec2

I put that in Firefox:General as it needs triaging.

Component: General → Privacy: Anti-Tracking
Product: Firefox → Core
Regressed by: 1507055
Duplicate of this bug: 1610492

Baku, can you take a look?

Flags: needinfo?(amarchesini)
Duplicate of this bug: 1610482
Assignee: nobody → amarchesini
Status: NEW → ASSIGNED

I just reproduced this crash when trying to reproduce Bug 1609910. I've done all the settings from https://bugzilla.mozilla.org/show_bug.cgi?id=1609910#c2 and entered and exited YouTube a couple of times. After the crash occurred I can no longer open Nightly with that profile.

Setting as blocker as we had >500 crashes over the last 2 hours with this signature.

Updates are disabled on the nightly channel.

Bug 1507055 was backed out and new nightlies are being spun.

We can land the fix together with bug 1507055.

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Flags: needinfo?(amarchesini)
Resolution: --- → INVALID

Comment on attachment 9122034 [details]
Bug 1610485 - AntiTrackingCommon::RedirectHeuristic must check the number of redirect entries, r?ehsan

Revision D60505 was moved to bug 1507055. Setting attachment 9122034 [details] to obsolete.

Attachment #9122034 - Attachment is obsolete: true

This was a valid bug, it was just fixed by backout.

Resolution: INVALID → FIXED
Target Milestone: --- → mozilla74
Duplicate of this bug: 1611157
You need to log in before you can comment on or make changes to this bug.