Attachment #8822388 for bug #1298588

Attachment #8822388: part 4. Recreate the default computed values for a document as needed for bug #1298588

View | Details | Raw Unified | Return to bug 1298588
Collapse All | Expand All





  PostRestyleEventInternal(true);
}

void
ServoRestyleManager::RebuildAllStyleData(nsChangeHint aExtraHint,
                                         nsRestyleHint aRestyleHint)
{
  NS_WARNING("stylo: ServoRestyleManager::RebuildAllStyleData not implemented");
  // That said, we do know that rebuilding all style data in Gecko would get rid
  // of the old ruletree, and hence of the cached-on-the-root default computed
  // styles.  So we know we need to clear them here.  I think this is the only
  // way they could get cleared, in fact, though not _all_ calls that come
  // through here may need to clear them in practice.
  //
  // We probably need to do some actual restyling here too, though.  And figure
  // out whether it actually matters that we may be recomputing the default
  // styles in too many cases.  For one thing, we do a bunch of eager work here,
  // whereas we should really just set a bit that says to recompute the default
  // computed styles before the next time we restyle anything!
  StyleSet()->RecomputeDefaultComputedStyles();
}

void
ServoRestyleManager::PostRebuildAllStyleDataEvent(nsChangeHint aExtraHint,
                                                  nsRestyleHint aRestyleHint)
{
  NS_WARNING("stylo: ServoRestyleManager::PostRebuildAllStyleDataEvent not implemented");
}





                   ThreadSafeURIHolder* base,
                   ThreadSafeURIHolder* referrer,
                   ThreadSafePrincipalHolder* principal)
SERVO_BINDING_FUNC(Servo_StyleSheet_HasRules, bool,
                   RawServoStyleSheetBorrowed sheet)
SERVO_BINDING_FUNC(Servo_StyleSheet_GetRules, ServoCssRulesStrong,
                   RawServoStyleSheetBorrowed sheet)
SERVO_BINDING_FUNC(Servo_StyleSet_Init, RawServoStyleSetOwned, RawGeckoPresContextBorrowed pres_context)
SERVO_BINDING_FUNC(Servo_StyleSet_RecomputeDefaultStyles, void,
                   RawServoStyleSetBorrowed set,
                   RawGeckoPresContextBorrowed pres_context)
SERVO_BINDING_FUNC(Servo_StyleSet_Drop, void, RawServoStyleSetOwned set)
SERVO_BINDING_FUNC(Servo_StyleSet_AppendStyleSheet, void,
                   RawServoStyleSetBorrowed set, RawServoStyleSheetBorrowed sheet, bool flush)
SERVO_BINDING_FUNC(Servo_StyleSet_PrependStyleSheet, void,
                   RawServoStyleSetBorrowed set, RawServoStyleSheetBorrowed sheet, bool flush)
SERVO_BINDING_FUNC(Servo_StyleSet_RemoveStyleSheet, void,
                   RawServoStyleSetBorrowed set, RawServoStyleSheetBorrowed sheet, bool flush)
SERVO_BINDING_FUNC(Servo_StyleSet_InsertStyleSheetBefore, void,

(-)a/layout/style/ServoStyleSet.cpp (+6 lines)

Line	Link Here

Lines 520-527 ServoStyleSet::NoteStyleSheetsChanged()	Link Here

520

void

520

void

521

ServoStyleSet::AssertTreeIsClean()

521

ServoStyleSet::AssertTreeIsClean()

522

523

  if (Element* root = mPresContext->Document()->GetRootElement()) {

523

  if (Element* root = mPresContext->Document()->GetRootElement()) {

524

    Servo_AssertTreeIsClean(root);

524

    Servo_AssertTreeIsClean(root);

525

526

527

#endif

527

#endif

528

529

void

530

ServoStyleSet::RecomputeDefaultComputedStyles()

531

532

  Servo_StyleSet_RecomputeDefaultStyles(mRawSet.get(), mPresContext);

533





  void NoteStyleSheetsChanged();

#ifdef DEBUG
  void AssertTreeIsClean();
#else
  void AssertTreeIsClean() {}
#endif

  /**
   * Recompute our default computed styles.  This will eagerly create a new set
   * of default computed style structs.
   */
  void RecomputeDefaultComputedStyles();

private:
  already_AddRefed<nsStyleContext> GetContext(already_AddRefed<ServoComputedValues>,
                                              nsStyleContext* aParentContext,
                                              nsIAtom* aPseudoTag,
                                              CSSPseudoElementType aPseudoType);

  already_AddRefed<nsStyleContext> GetContext(nsIContent* aContent,
                                              nsStyleContext* aParentContext,





    pub fn Servo_StyleSheet_GetRules(sheet: RawServoStyleSheetBorrowed)
     -> ServoCssRulesStrong;
}
extern "C" {
    pub fn Servo_StyleSet_Init(pres_context: RawGeckoPresContextBorrowed)
     -> RawServoStyleSetOwned;
}
extern "C" {
    pub fn Servo_StyleSet_RecomputeDefaultStyles(set:
                                                     RawServoStyleSetBorrowed,
                                                 pres_context:
                                                     RawGeckoPresContextBorrowed);
}
extern "C" {
    pub fn Servo_StyleSet_AppendStyleSheet(set: RawServoStyleSetBorrowed,
                                           sheet: RawServoStyleSheetBorrowed,
                                           flush: bool);
}
extern "C" {
    pub fn Servo_StyleSet_PrependStyleSheet(set: RawServoStyleSetBorrowed,
                                            sheet: RawServoStyleSheetBorrowed,
                                            flush: bool);





#[no_mangle]
pub extern "C" fn Servo_StyleSet_Init(pres_context: RawGeckoPresContextBorrowed)
  -> RawServoStyleSetOwned {
    let data = Box::new(PerDocumentStyleData::new(pres_context));
    data.into_ffi()
}

#[no_mangle]
pub extern "C" fn Servo_StyleSet_RecomputeDefaultStyles(
  raw_data: RawServoStyleSetBorrowed,
  pres_context: RawGeckoPresContextBorrowed) {
    let mut data = PerDocumentStyleData::from_ffi(raw_data).borrow_mut();
    data.default_computed_values = ComputedValues::default_values(pres_context);
}

#[no_mangle]
pub extern "C" fn Servo_StyleSet_Drop(data: RawServoStyleSetOwned) -> () {
    let _ = data.into_box::<PerDocumentStyleData>();
}


#[no_mangle]
pub extern "C" fn Servo_ParseProperty(property: *const nsACString, value: *const nsACString,
                                      base_url: *const nsACString, base: *mut ThreadSafeURIHolder,

Return to bug 1298588