Attachment 57390 Details for Bug 101982

[patch] hack to editor.js that covers all cases

101982-a.diffs.txt (text/plain), 1.14 KB, created by Chris Waterson

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Waterson

Size: 1.14 KB

patch

obsolete

>Index: editor.js
>===================================================================
>RCS file: /cvsroot/mozilla/editor/ui/composer/content/editor.js,v
>retrieving revision 1.125
>diff -u -r1.125 editor.js
>--- editor.js	2001/10/31 00:12:28	1.125
>+++ editor.js	2001/11/10 22:39:59
>@@ -2038,6 +2038,10 @@
>   var state = commandNode.getAttribute("state");
> 
>   button.checked = state == "true";
>+
>+  // XXX why doesn't button.checked make the right thing happen here?
>+  // Did it ever?
>+  button.setAttribute("checked", state);
> }
> 
> //--------------------------------------------------------------------
>@@ -2047,6 +2051,10 @@
>   var state = commandNode.getAttribute("state");
> 
>   button.checked = state == onState;
>+
>+  // XXX why doesn't button.checked make the right thing happen here?
>+  // Did it ever?
>+  button.setAttribute("checked", state == onState);
> }
> 
> 
>@@ -2064,6 +2072,10 @@
>   if (theButton)
>   {
>     theButton.checked = isOn == "true";
>+
>+    // XXX why doesn't button.checked make the right thing happen
>+    // here?  Did it ever?
>+    theButton.setAttribute("checked", isOn);
>   }
> 
>   var theMenuItem = document.getElementById(theStyle + "MenuItem");

Flags:

cmanske: review+
cmanske: superreview+

Actions: View | Diff | Review

Attachments on bug 101982: 57386 | 57387 | 57388 | 57390 | 57392 | 57986