Attachment 57986 Details for Bug 101982

[patch] Remove unnecessary "setAttribute" calls for "checked" toolbar buttons

BugFix_101982b.txt (text/plain), 1021 bytes, created by Charles Manske

(hide)

Description:

Filename:

MIME Type:

Creator: Charles Manske

Size: 1021 bytes

patch

obsolete

>Index: editor.js
>===================================================================
>RCS file: /cvsroot/mozilla/editor/ui/composer/content/editor.js,v
>retrieving revision 1.126
>diff -u -r1.126 editor.js
>--- editor.js	2001/11/15 15:28:06	1.126
>+++ editor.js	2001/11/15 22:24:07
>@@ -1969,10 +1969,6 @@
>   var commandNode = document.getElementById(commmandID);
>   var state = commandNode.getAttribute("state");
>   button.checked = state == "true";
>-
>-  // XXX why doesn't button.checked make the right thing happen here?
>-  // Did it ever?
>-  button.setAttribute("checked", state);
> }
> 
> //--------------------------------------------------------------------
>@@ -1982,10 +1978,6 @@
>   var state = commandNode.getAttribute("state");
> 
>   button.checked = state == onState;
>-
>-  // XXX why doesn't button.checked make the right thing happen here?
>-  // Did it ever?
>-  button.setAttribute("checked", state == onState);
> }
> 
> // --------------------------- Status calls ---------------------------

Flags:

Brade: review+
kinmoz: superreview+

Actions: View | Diff | Review

Attachments on bug 101982: 57386 | 57387 | 57388 | 57390 | 57392 | 57986