Attachment 8632256 Details for Bug 1100602

[patch] add show/hide events in HTMLLIAccessible::UpdateBulletlist

proxyshutdown (text/plain), 1.78 KB, created by Lorien Hu (:lsocks)

(hide)

Description:

Filename:

MIME Type:

Creator: Lorien Hu (:lsocks)

Size: 1.78 KB

patch

obsolete

># HG changeset patch
># User Lorien Hu <lorien@lorienhu.com>
># Date 1436555126 14400
>#      Fri Jul 10 15:05:26 2015 -0400
># Node ID c7c9f46e652be4601eb0870816927d5024d0626b
># Parent  f7e1f596d57d2c112685172a3b708f1cb0eaf93b
>Bug 1100602 - Fire show/hide events in HTMLLIAccessible::UpdateBullet
>
>diff --git a/accessible/html/HTMLListAccessible.cpp b/accessible/html/HTMLListAccessible.cpp
>--- a/accessible/html/HTMLListAccessible.cpp
>+++ b/accessible/html/HTMLListAccessible.cpp
>@@ -97,29 +97,39 @@ HTMLLIAccessible::Bounds() const
> void
> HTMLLIAccessible::UpdateBullet(bool aHasBullet)
> {
>   if (aHasBullet == !!mBullet) {
>     NS_NOTREACHED("Bullet and accessible are in sync already!");
>     return;
>   }
> 
>+  nsRefPtr<AccReorderEvent> reorderEvent = new AccReorderEvent(this);
>+  AutoTreeMutation mut(this);
>+
>   DocAccessible* document = Document();
>   if (aHasBullet) {
>     mBullet = new HTMLListBulletAccessible(mContent, mDoc);
>     document->BindToDocument(mBullet, nullptr);
>     InsertChildAt(0, mBullet);
>+
>+    nsRefPtr<AccShowEvent> event = new AccShowEvent(mBullet, mBullet->GetContent());
>+    mDoc->FireDelayedEvent(event);
>+    reorderEvent->AddSubMutationEvent(event);
>   } else {
>+    nsRefPtr<AccHideEvent> event = new AccHideEvent(mBullet, mBullet->GetContent());
>+    mDoc->FireDelayedEvent(event);
>+    reorderEvent->AddSubMutationEvent(event);
>+
>     RemoveChild(mBullet);
>     document->UnbindFromDocument(mBullet);
>     mBullet = nullptr;
>   }
> 
>-  // XXXtodo: fire show/hide and reorder events. That's hard to make it
>-  // right now because coalescence happens by DOM node.
>+  mDoc->FireDelayedEvent(reorderEvent);
> }
> 
> ////////////////////////////////////////////////////////////////////////////////
> // HTMLLIAccessible: Accessible protected
> 
> void
> HTMLLIAccessible::CacheChildren()
> {

Flags:

tbsaunde: feedback+

Actions: View | Diff | Review

Attachments on bug 1100602: 8623368 | 8632256 | 8633075 | 8633076 | 8633511 | 8633526