Attachment 137275 Details for Bug 228176

[patch] Proposed patch

228176.diff (text/plain), 1.83 KB, created by neil@parkwaycc.co.uk

(hide)

Description:

Filename:

MIME Type:

Creator: neil@parkwaycc.co.uk

Size: 1.83 KB

patch

obsolete

>Index: xpcom/io/nsEscape.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/xpcom/io/nsEscape.cpp,v
>retrieving revision 1.25
>diff -p -u -d -r1.25 nsEscape.cpp
>--- xpcom/io/nsEscape.cpp	15 Mar 2003 01:04:11 -0000	1.25
>+++ xpcom/io/nsEscape.cpp	12 Dec 2003 00:03:36 -0000
>@@ -434,7 +434,7 @@ NS_COM PRBool NS_UnescapeURL(
>     if (len < 0)
>         len = strlen(str);
> 
>-    PRBool ignoreNonAscii = (flags & esc_OnlyASCII);
>+    PRBool ignoreAscii = (flags & esc_OnlyNonASCII);
>     PRBool writing = (flags & esc_AlwaysCopy);
> 
>     static const char hexChars[] = "0123456789ABCDEFabcdef";
>@@ -447,7 +447,7 @@ NS_COM PRBool NS_UnescapeURL(
>         if (*p == HEX_ESCAPE && i < len-2) {
>             unsigned char *p1 = ((unsigned char *) p) + 1;
>             unsigned char *p2 = ((unsigned char *) p) + 2;
>-            if (ISHEX(*p1) && ISHEX(*p2) && !(ignoreNonAscii && *p1 >= '8')) {
>+            if (ISHEX(*p1) && ISHEX(*p2) && !(ignoreAscii && *p1 < '8')) {
>                 //printf("- p1=%c p2=%c\n", *p1, *p2);
>                 writing = PR_TRUE;
>                 if (p > last) {
>Index: docshell/base/nsWebShell.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/docshell/base/nsWebShell.cpp,v
>retrieving revision 1.622
>diff -p -u -d -r1.622 nsWebShell.cpp
>--- docshell/base/nsWebShell.cpp	21 Nov 2003 00:09:44 -0000	1.622
>+++ docshell/base/nsWebShell.cpp	12 Dec 2003 00:03:37 -0000
>@@ -706,7 +706,7 @@ nsWebShell::OnOverLink(
>     NS_ENSURE_SUCCESS(rv, rv);
> 
>     nsAutoString uStr;
>-    rv = textToSubURI->UnEscapeURIForUI(charset, spec, uStr);    
>+    rv = textToSubURI->UnEscapeNonAsciiURI(charset, spec, uStr);    
> 
>     if (NS_SUCCEEDED(rv))
>       rv = browserChrome->SetStatus(nsIWebBrowserChrome::STATUS_LINK, uStr.get());

Actions: View | Diff | Review

Attachments on bug 228176: 137275 | 137564 | 137585 | 137693

Bugzilla

Quick Search

Attachment 137275 Details for Bug 228176