Bugzilla

(In reply to :Gijs (he/him) from comment #3)
> The recent screenshot you added is for a modal, not a notification bar, and is limiting the height of the browser window rather than the width. I suspect that issue would be better off as a new bug. WRT that bug, it would be good to clarify if you resized the browser window after the dialog showed up or before? Does it make a difference to the outcome?
> 
> For the notification bar that was the subject of this original bug, it looks like this was moved in bug 1656494 and is now in https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/asrouter/modules/CFRMessageProvider.sys.mjs#773-791 . I don't know how to test triggering that, or if that message and CFR is in active use, or if it could be removed from the code. Shane?

That's a different message, actually a no-op archive of a message. The `targeting: "false"` negates it. The message in the screenshot is the [DefaultBrowserCheck prompt](https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/BrowserGlue.sys.mjs#5420) (see [strings here](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/defaultBrowserNotification.ftl)). OMC doesn't currently control it, but we have been considering taking it over and converting it to our messaging system (bug 1825381).

To test it, there are [several checks](https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/BrowserGlue.sys.mjs#5503) that need to be passed. The main reason we don't see it much is there's a [RELEASE_OR_BETA check](https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/BrowserGlue.sys.mjs#5578). (Is there a way to override that constant for a local build? That would sure be nice.) Anyway, here are some steps:
- OS = Windows
- release build
- build is not set to default browser
- make a new profile, and set it to default profile
- run it
- restart firefox
- it should show the prompt up to 3 times, but you can reset it with `browser.shell.defaultBrowserCheckCount`

(In reply to :Gijs (he/him) from comment #3)
> The recent screenshot you added is for a modal, not a notification bar, and is limiting the height of the browser window rather than the width. I suspect that issue would be better off as a new bug. WRT that bug, it would be good to clarify if you resized the browser window after the dialog showed up or before? Does it make a difference to the outcome?
> 
> For the notification bar that was the subject of this original bug, it looks like this was moved in bug 1656494 and is now in https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/asrouter/modules/CFRMessageProvider.sys.mjs#773-791 . I don't know how to test triggering that, or if that message and CFR is in active use, or if it could be removed from the code. Shane?

That's a different message, actually a no-op archive of a message. The `targeting: "false"` negates it. The message in the screenshot is the [DefaultBrowserCheck prompt](https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/BrowserGlue.sys.mjs#5420) (see [strings here](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/defaultBrowserNotification.ftl)). OMC doesn't currently control it, but we have been considering taking it over and converting it to our messaging system (bug 1825381).

To test it, there are [several checks](https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/BrowserGlue.sys.mjs#5503) that need to be passed. The main reason we don't see it much is there's a [RELEASE_OR_BETA check](https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/BrowserGlue.sys.mjs#5578). (Is there a way to override that constant for a local build? That would sure be nice.) Anyway, here are some steps:
1. OS = Windows
2. release build
3. build is not set to default browser
4. make a new profile, and set it to default profile
5. run it
6. restart firefox
7. it should show the prompt up to 3 times, but you can reset it with `browser.shell.defaultBrowserCheckCount`