Bugzilla

(In reply to Simon Farre [:sfarre] from comment #67)
> Yeah it's difficult to tell what the test actually is testing because it's just magic numbers and no explanation.
> 
> I will need-info the people who has worked on it. :nchevobbe you seem to have touched the test, can you explain what's going on? Is this just a matter of bumping the expected number from 37 to 39?

The test adds a `location` watch expression in the debugger and expands it so we have all its properties displayed.
You patch adds `ancestorOrigins` and we also show the getter node (see screenshot). So yes, we have 2 additional properties now, and we should bump the number from 37 to 39

(In reply to Simon Farre [:sfarre] from comment #67)
> Yeah it's difficult to tell what the test actually is testing because it's just magic numbers and no explanation.
> 
> I will need-info the people who has worked on it. :nchevobbe you seem to have touched the test, can you explain what's going on? Is this just a matter of bumping the expected number from 37 to 39?

The test adds a `location` watch expression in the debugger and expands it so we have all its properties displayed.
You patch adds `ancestorOrigins` and we also show the getter node (see screenshot). So yes, we have 2 additional properties now, and we should bump the number from 37 to 39
The same goes for the two failing assertions in `devtools/client/debugger/test/mochitest/browser_dbg-expressions.js`