So does that mean we go for 68.1.1 or 68.2? Surely you've viewed some valid S/MIME messages and they're still displayed OK, right? Plus we have some tests that cover the most common scenarios. I discussed this with Magnus and he and I are cool to ship this in 68.1.1. Could you do an ESR68 try run with your patches. Please backout https://hg.mozilla.org/releases/comm-esr68/rev/af3c68874f9b040b1751db49e8e041e7330c4651 as part of the try since it caused Mochitest (bct) failures.
Bug 1240290 Comment 109 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
So does that mean we go for 68.1.1 or 68.2? Surely you've viewed some valid S/MIME messages and they're still displayed OK, right? Plus we have some tests that cover the most common scenarios. I discussed this with Magnus and he and I are cool to ship this in 68.1.1. Could you do an ESR68 try run with your patches. Please backout https://hg.mozilla.org/releases/comm--esr68/rev/af3c68874f9b040b1751db49e8e041e7330c4651 (EDIT: destroyed link) as part of the try since it caused Mochitest (bct) failures.