Bug 1313577 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Prathiksha, I don't think the patch in this bug fixes the issue that's described. Note that setting the captive portal tab binding to null has little to no effect since the reference is weak [1].

The purpose of this bug was to stop treating the captive portal tab as a captive portal tab, if the *portal* page redirected to some third-party site. This is hard to detect and at the moment I don't have a solution in mind.

Could you chime in here and re-open the bug if necessary?
Prathiksha, I don't think the patch in this bug fixes the issue that's described. Note that setting the captive portal tab binding to null has little to no effect since the reference is weak [1].

The purpose of this bug was to stop treating the captive portal tab as a captive portal tab, if the *portal* page redirected to some third-party site. This is hard to detect and at the moment I don't have a solution in mind.

Could you chime in here and re-open the bug if necessary?

[1] https://searchfox.org/mozilla-central/rev/f36cb2af46edd2659f446b7acdb2154e230ee445/browser/base/content/browser-captivePortal.js#288

Back to Bug 1313577 Comment 10